Closed Bug 323288 Opened 14 years ago Closed 14 years ago

MOZB/MOZC creator code already used for Firefox/Camino

Categories

(Calendar :: General, defect)

PowerPC
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: desmedt, Assigned: hecker)

References

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

On Mac OSX, Sunbird 0.3 still has the creator code MOZB which unfortunately is also that of Firefox.  This clash causes Sunbird to crash when hyperlinks intended to be opened with Firefox are opened with Sunbird instead.

Reproducible: Always

Steps to Reproduce:
1. Firefox not running, Sunbird running.
2. Click on hyperlink in any app, or open any file with creator MOZB.
3.

Actual Results:  
Sunbird tries to open the link or file and crashes.

Expected Results:  
Firefox should open link or file.


On Mac OSX, Sunbird should get a creator code different from that of Firefox.
Maybe MOZC ?
Attached patch use MOZC for CFBundleSignature (obsolete) — Splinter Review
According to lxr Firefox uses MOZB (b is for browser), Thunderbird uses MOZM (m is for mail). So using MOZC (c for calendar) sounds good to me. 
Patch is not tested because of missing Mac OS.

dmose: 
If you are not the appropriate reviewer for this patch please forward to the correct person.
Attachment #208398 - Flags: first-review?(dmose)
Assignee: mostafah → ssitter
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 281531 has been marked as a duplicate of this bug. ***
Comment on attachment 208398 [details] [diff] [review]
use MOZC for CFBundleSignature

r=dmose
Attachment #208398 - Flags: first-review?(dmose) → first-review+
Fix checked in; thanks for the patch, Stefan!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
The patch works, at least for OS 10.3.9.  NOTE, however, that MOZB must be changed to MOZC in both the Info.plist AND the PkgInfo files in order to work.
(In reply to comment #5)
> The patch works, at least for OS 10.3.9.  NOTE, however, that MOZB must be
> changed to MOZC in both the Info.plist AND the PkgInfo files in order to work.

Sorry, I don't see that file you mentioned. http://lxr.mozilla.org/mozilla/find?string=PkgInfo shows no file with that name that belongs to calendar.
(In reply to comment #5)
> The patch works, at least for OS 10.3.9.  NOTE, however, that MOZB must be
> changed to MOZC in both the Info.plist AND the PkgInfo files in order to work.

These two sentences seem to contradict each other.  Please explain how the patch can simultaneously both work and not work.
sipaq find the place to change: http://lxr.mozilla.org/mozilla/source/calendar/sunbird/app/Makefile.in#291
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch use MOZC for PkgInfo too (obsolete) — Splinter Review
Attachment #209216 - Flags: first-review?(dmose)
Comment on attachment 209216 [details] [diff] [review]
use MOZC for PkgInfo too

r=dmose
Attachment #209216 - Flags: first-review?(dmose) → first-review+
Fix checked in; thanks Stefan!
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
KDS and resimmons@hotmail.com could you please verify that this patch really fixes this issue with tomorrow's nightly build. Thanks.
No good, we're using MOZC for Camino.  You should register your creator type with Apple at http://developer.apple.com/datatype/ to ensure uniqueness.  Their database accurately identifies MOZC as in use.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The MOZS creator code is still free, and could therefore be an alternative.
I can create a new patch if someone from Mozilla Foundation registers a creator code for Sunbird. MOZS sounds like a reasonable alternative. (http://developer.apple.com/datatype/creatorcode.html)
Summary: MOZB creator code clashes with Firefox → MOZB/MOZC creator code already used for Firefox/Camino
Version: unspecified → Trunk
(In reply to comment #15)
> I can create a new patch if someone from Mozilla Foundation registers a creator
> code for Sunbird. MOZS sounds like a reasonable alternative.
> (http://developer.apple.com/datatype/creatorcode.html)

We could also use MOZc 
Type/creators are case-sensitive
(Is it really the case that all Mac apps need to be serialized through this code assignment, or are our apps special in some way that makes them all need this?)
shaver has the info re: registering creators with Apple.
Attachment #208398 - Attachment is obsolete: true
Attachment #209216 - Attachment is obsolete: true
Attachment #216584 - Flags: first-review?
You don't need a creator code if you don't associate files with yourself or don't need other apps to be able to find and launch yours.  In that case, you use creator '????'.

Registration itself is optional but it avoids collisions, as most Mac developers know to check the registry.
Comment on attachment 216584 [details] [diff] [review]
rev2 - Move creator code to a variable, and stop using Camino's

I'm not a calendar member, but this looks OK.  I have a preference for sed replacements to be done on @VAR@ to make them clear in the .in files, but it's OK either way.
So does Sunbird need the things that are only possible if a creator code is used?  This whole creator code thing seems pretty broken to me (I have 6 Firefoxes on my laptop, and they all have/use the same creator code -- how does the system distinguish between them?) but if we really need it then we really need it.
(In reply to comment #21)
> So does Sunbird need the things that are only possible if a creator code is
> used? 

Keep in mind that every Panther and above system has iCal.app on it, and therefore .ics files created by Sunbird will likely launch iCal.app instead of Sunbird when double-clicked.

Given that, I think it's worth it.

(In reply to comment #21)
> So does Sunbird need the things that are only possible if a creator code is
> used?

I think it does.  lilmatt seems to agree.

> This whole creator code thing seems pretty broken to me

It kind of is.

> (I have 6
> Firefoxes on my laptop, and they all have/use the same creator code -- how
> does the system distinguish between them?)

Poorly.

If an app with the target creator is already open, the system will route things to that one.  Otherwise, whoever shows up first in the LaunchServices database wins.  Whoever wins that race, though, is anyone's guess.  You can poke around in the LS database with the lsregister tool (buried somewhere in ApplicationServices.framework) if you're so inclined.

Most users only hold on to one copy of an app.  It's more of a pain for developers than anyone else.
Attachment #216584 - Flags: first-review? → first-review?(dmose)
Assignee: ssitter → nobody
Status: REOPENED → NEW
Taking this.

nominating for Sb 0.3a2 blocker

We shouldn't let another release go out with Firefox's or Camino's creator code, even if we have to use ????.
Status: NEW → ASSIGNED
Comment on attachment 216584 [details] [diff] [review]
rev2 - Move creator code to a variable, and stop using Camino's

r+ if you change the Info.plist.in and the appropriate sed command to use @MAC_CREATOR_CODE@.  This is the autoconf convention to make it clear to the reader that the string is going to be interpreted rather than used literally.
Attachment #216584 - Flags: first-review?(dmose) → first-review+
Assignee: nobody → mattwillis
Status: ASSIGNED → NEW
rev2 checked in to 1.8 branch and trunk with dmose's/mento's suggestion for using autoconf-style variables with sed.

shaver will be getting MoFo/MoCo to register MOZc with Apple.
Assigning this to him for that.
Assignee: mattwillis → shaver
Taking this as I'm driving it with hecker
Status: NEW → ASSIGNED
Is this done?  Was MOZc registered (http://developer.apple.com/datatype/creatorcode.html)?
(In reply to comment #28)
> Is this done?  Was MOZc registered
> (http://developer.apple.com/datatype/creatorcode.html)?

According to Apple's page, no. Last I knew registering it was in Frank Hecker's hands.
Assignee: shaver → hecker
Status: ASSIGNED → NEW
My apologies for dropping the ball on this (which I think I did). I just now submitted a registration application for "MOZc", associating it with product "Sunbird". I'll comment again here when I get email confirmation from Apple.
Status: NEW → ASSIGNED
(In reply to comment #30)
> My apologies for dropping the ball on this (which I think I did). I just now
> submitted a registration application for "MOZc", associating it with product
> "Sunbird". I'll comment again here when I get email confirmation from Apple.

I just got an official email from Apple confirming the registration of "MOZc" for Sunbird. I'm not sure if it's yet in the official published list codes (a quick check indicates that the code is still available, i.e., not registered), but we can verify that in the next few days.
I just searched on MOZc at http://developer.apple.com/datatype/search.html

Search for a Creator Code
Creator Type Search Results

The following creators are already claimed by a developer:

    * MOZc


-> FIXED 
Status: ASSIGNED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
-> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.