323402 - Memory leak when update firefox and select 'Later' to restart later

Status: RESOLVED DUPLICATE of bug 401907

(Toolkit :: Application Update, defect)

Description

[u88484]

I firgure there had been a memory leak when you update and did not restart and finally proved it with dbarons leak-gauge.pl script.

Steps to reproduce:
1) Make sure you are a day or two behind in updates.
2) Start Firefox with all extensions disabled, default theme, about:blank as homepage.
3) Help->Check for updates, click download and install
4) When prompted to restart select 'Later' Close firfox. Run the script over the log. And you'll get something like these (I needed to two updates)


1st time with extensions and been surfing pages:

Leaked outer window 2e59b98 at address 2e59b98.
Leaked outer window 1d316f0 at address 1d316f0.
Leaked inner window 2b1b118 (outer 1d316f0) at address 2b1b118.
 ... with URI "http://maddox.xmission.com/".
Leaked outer window 14ae148 at address 14ae148.
Leaked inner window 296d570 (outer 30b30a0) at address 296d570.
 ... with URI "http://us.f365.mail.yahoo.com/dc/blank.html".
Leaked outer window 30b30a0 at address 30b30a0.
Leaked outer window 3990350 at address 3990350.
Leaked inner window 26e9810 (outer 1d316f0) at address 26e9810.
 ... with URI "http://us.f365.mail.yahoo.com/dc/launch?action=welcome&YY=9959094
17&.rand=funqeqe9j55cv".
Leaked inner window 3951d08 (outer 3990350) at address 3951d08.
 ... with URI "chrome://mozapps/content/update/updates.xul".
Leaked inner window 1438808 (outer 14ae148) at address 1438808.
 ... with URI "about:blank".
Leaked document at address 272f4e0.
 ... with URI "http://us.f365.mail.yahoo.com/dc/blank.html".
Leaked document at address 26f3820.
 ... with URI "http://us.f365.mail.yahoo.com/dc/launch?action=welcome&YY=9959094
17&.rand=funqeqe9j55cv".
Leaked document at address 32bd0f8.
 ... with URI "https://aus2.mozilla.org/update/1/Firefox/1.6a1/2006011205/WINNT_
x86-msvc/en-US/nightly/update.xml".
Summary:
Leaked 10 out of 282 DOM Windows
Leaked 3 out of 416 documents
Leaked 0 out of 103 docshells


2nd time with no extensions, default theme, only page loaded was about:blank.

C:\Program Files\Mozilla Firefox>perl leak-gauge.pl nspr.log
Leaked inner window 1cacea8 (outer 1c53638) at address 1cacea8.
 ... with URI "chrome://mozapps/content/update/updates.xul".
Leaked outer window 1c53638 at address 1c53638.
Summary:
Leaked 2 out of 12 DOM Windows
Leaked 0 out of 48 documents
Leaked 0 out of 6 docshells

Comment 1

[Peter van der Woude [:Peter6]]

Confirmed:
new profile only Update Channel Selector extension installed

Leaked outer window 278ca98 at address 278ca98.
Leaked inner window 2126c40 (outer 278ca98) at address 2126c40.
 ... with URI "chrome://mozapps/content/update/updates.xul".

Summary:
Leaked 2 out of 16 DOM Windows
Leaked 0 out of 60 documents
Leaked 0 out of 8 docshells

Comment 2

[u88484]

I always thought there was a leak after doing that. I always upgrade that way by hitting 'Later' because I want to continue surfing for a while. Well sometimes that turns into an hour and firefox starts to beomce very unresponsive and buggy like tabs taking forever for the titles to update and status bar to update and things like that.

Comment 3

[Peter van der Woude [:Peter6]]

New profile, no extensions, no live bookmarks (to avoid any outside inteference), same result

Leaked outer window 1f3c938 at address 1f3c938.
Leaked inner window 219f860 (outer 1f3c938) at address 219f860.
 ... with URI "chrome://mozapps/content/update/updates.xul".

Summary:
Leaked 2 out of 12 DOM Windows
Leaked 0 out of 37 documents
Leaked 0 out of 6 docshells

Comment 4

[u88484]

Requesting blocking. I donno how severe of a leak this is because recently I've been restarting instead of waiting but when I used to click later it seems firefox would slow to a craw after about minutes of surfing so I assume its a pretty big leak.

Comment 5

[Régis Caspar]

Dupe of #336955 ?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 336955 ***

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

*** Bug 343272 has been marked as a duplicate of this bug. ***

Comment 8

[Adam Guthrie]

This was duped incorrectly. Reopening...

Comment 9

[Adam Guthrie]

Attachment: leak log

Comment 10

[Haudy Kazemi]

I can confirm I have seen the same bug that Adam Guthrie added to here (and had originally reported on bug 343272, which is currently considered a duplicate of this bug).  I am using Leak Monitor 0.3.4

I'm not sure that the bug that Adam and I are reported are the same as the bug this report was created for.

I saw the bug while going from Bon Echo 2.0a3 nightly 2006070304 to Bon Echo 2.0a3 nightly 2006070404.  The file I am about to attach is my Leak Monitor log, which is very similar to Adam's log, except that mine is for a later Windows build and was partial upgrade.  Other than that, the two match up very closely.  I have only seen the bug once so far, so I think it is a rare bug.

Comment 11

[Haudy Kazemi]

Attachment: FF2.0a3 update leak seen on 20060703 to 20060704 update

Very similar to Adam's Leak Monitor report.

Comment 12

[Haudy Kazemi]

Attachment: FF2.0b1 update leak seen on 20060708 to 20060709 update

Bug repeated itself.  Leak Monitor report attached.
(FF2.0b1 update leak seen on 20060708 to 20060709 update.)

Comment 13

[u88484]

(In reply to comment #12)
> Created an attachment (id=228654) [edit]
> FF2.0b1 update leak seen on 20060708 to 20060709 update
> 
> Bug repeated itself.  Leak Monitor report attached.
> (FF2.0b1 update leak seen on 20060708 to 20060709 update.)
> 

Thanks for the logs Haudy. This has been confirmed already so no need for more comments and logs.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

*** Bug 344708 has been marked as a duplicate of this bug. ***

Comment 15

[Haudy Kazemi]

This is still leaking as of Mozilla/5.0 (Windows;;; en-US; rv:1.8.1b2) Gecko/20060826 BonEcho/2.0b2 ID:2006082605 .

Leak Monitor says it is leaking in
'xpconnect wrapped (nsISupports, nsIUpdate, nsIWritablePropertyBag)'

Comment 16

[Toby Haynes]

Still leaking as of Firefox update to 2.0.0.2 when selecting "Later":

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/2006120814 Firefox/2.0.0.1

Leaks in window 0x9fe5ea0:
[+] [leaked object] (a5e8018) = [Object]
 [+] _update (9e7fc30) = [XPCWrappedNative_NoHelper]
  [ ] QueryInterface (a018f50) = [Function]
  [ ] selectedPatch = true
  [ ] name = true
  [ ] detailsURL = true
  [ ] type = true
  [ ] version = true
  [ ] extensionVersion = true
  [ ] buildID = true
  [ ] licenseURL = true
  [ ] serviceURL = true
  [ ] isCompleteUpdate = true
  [ ] isSecurityUpdate = true
  [ ] installDate = true
  [ ] statusText = true
  [ ] state = true
  [ ] errorCode = true
  [ ] patchCount = true
  [+] getPatchAt (9ba06a8) = [Function]
   [ ] prototype (9d272b8) = [Object]
  [+] serialize (9ba02b0) = [Function]
   [ ] prototype (9d273d0) = [Object]
  [ ] enumerator = true
  [+] getProperty (9bde8e8) = [Function]
   [ ] prototype (9d27770) = [Object]
  [+] setProperty (9c97638) = [Function]
   [ ] prototype (9d27b30) = [Object]
  [+] deleteProperty (9c975e8) = [Function]
   [ ] prototype (9c97458) = [Object]
 [ ] _methodName = showUpdateComplete
 [+] _prompter (a5e7f58) = [XPCWrappedNative_NoHelper]
  [+] QueryInterface (97f4f58) = [Function]
   [ ] prototype (9deae18) = [Object]
  [+] checkForUpdates (97f4c88) = [Function]
   [ ] prototype (9deb138) = [Object]
  [+] showUpdateAvailable (97f3db0) = [Function]
   [ ] prototype (9d26458) = [Object]
  [+] showUpdateDownloaded (984f0f0) = [Function]
   [ ] prototype (9d26508) = [Object]
  [+] showUpdateInstalled (984f0d8) = [Function]
   [ ] prototype (9d26540) = [Object]
  [+] showUpdateError (98f1750) = [Function]
   [ ] prototype (9d26780) = [Object]
  [+] showUpdateHistory (99bb7d0) = [Function]
   [ ] prototype (9d26f48) = [Object]

Comment 17

[Steve Chapel]

I didn't get any memory leaks updating Firefox 3 beta 1 to Firefox 3 beta 2 and following the instructions in comment 0 on Windows XP.

leak-gauge.pl reports:

Summary:
Leaked 0 out of 38 DOM Windows
Leaked 0 out of 75 documents
Leaked 0 out of 13 docshells

Can anyone reproduce this leak by updating one Firefox 3 beta to another or one Firefox 3 nightly build to another?

Comment 18

[Matp75]

It was probably fixed for firefox 3 by bug 401907

Comment 19

[Steve Chapel]

I guess this is a duplicate.