323928 - Get print spooling working on Linux

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Stuart Parmenter]

We need to hook up the PDF cairo backend for printing on Linux.

Comment 1

[Calum Mackay]

mebbe change the OS to Linux? :)

Comment 2

[Stuart Parmenter]

printing is now "in" on linux in cairo builds.  it simply prints to a file at the moment.  there are numerous bugs and more work coming soon.

Comment 3

[jensemann]

(In reply to comment #2)
> there are numerous bugs and more work coming soon.

What do you mean with "comming soon"? :-)

Printing should work as it does with 2.0, print through a printing-system on linux, e.g. the default one or a given one in prefs.js

Comment 4

[Stuart Parmenter]

*** Bug 335754 has been marked as a duplicate of this bug. ***

Comment 5

[Stuart Parmenter]

Attachment: v0.75

Comment 6

[Stuart Parmenter]

patch from mwsteele.  need to copy a few files in cvs and should be mostly good-to-go

Comment 7

[Stuart Parmenter]

Attachment: good enough for now

this gets things working.  someone else can make it suck less.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 246994 [details] [diff] [review]
good enough for now

Good enough for now.

Comment 9

[Shawn Wilsher :sdwilsh]

This seems to have broken something - 
/Developer/mozilla/widget/src/cocoa/../mac/nsDeviceContextSpecX.h:93: error: 'virtual nsresult nsDeviceContextSpecX::BeginDocument(PRUnichar*, PRUnichar*, PRInt32, PRInt32)' and 'virtual nsresult nsDeviceContextSpecX::BeginDocument(PRUnichar*, PRUnichar*, PRInt32, PRInt32)' cannot be overloaded
/Developer/mozilla/widget/src/cocoa/../mac/nsDeviceContextSpecX.h:95: error: 'virtual nsresult nsDeviceContextSpecX::EndDocument()' and 'virtual nsresult nsDeviceContextSpecX::EndDocument()' cannot be overloaded

That is from this patch, no?

Comment 10

[Stuart Morgan]

Yes, this created duplicate declarations and definitions of BeginDocument and EndDocument on the Mac.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

This (or perhaps the bustage fix) broke my build
/home/smaug/mozilla/mozilla_cvs/mozilla/gfx/src/psshared/nsPSPrinters.cpp:42:65:  error: nsIDeviceContextSpecPS.h:12:34 No such file or directory

Comment 12

[Frederic Bezies]

I opened bug 362335 about this missing file issue.

Comment 13

[Andrew Benton]

Well printing works now (thanks for that), but it still leaves a mozilla.ps file in my home folder.

Comment 14

[Arne John Glenstrup]

(In reply to comment #13)

I opened bug 362357 about that strange feature.

Comment 15

[Oleg Romashin (:romaxa)]

Comment on attachment 246994 [details] [diff] [review]
good enough for now

>+#ifndef >nsPrintJobGTK_h__
>+#define >nsPrintJobGTK_h__
>+
>+#include "nsCUPSShim.h"
This file not exists if not defined MOZ_ENABLE_POSTSCRIPT
>+#include "nsDebug.h"
>+#include >"nsIDeviceContext.h"   >// for

Comment 16

[Bill Gianopoulos [:WG9s]]

This appears to have caused the crash immediately following printing that I reported in bug 362476.  This crash is also occurring with the Windows 1.9a1 candidate builds.

Comment 17

[Oleg Romashin (:romaxa)]

Attachment: Build Fixe if MOZ_ENABLE_POSTSCRIPT not defined

Comment 18

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 247531 [details] [diff] [review]
Build Fixe if MOZ_ENABLE_POSTSCRIPT not defined

bouncing this review to stuart

Comment 19

[Mats Palmgren (inactive)]

Comment on attachment 247531 [details] [diff] [review]
Build Fixe if MOZ_ENABLE_POSTSCRIPT not defined

>+CPPSRCS		= \

Shouldn't this be += ?

Comment 20

[Wolfgang Rosenauer [:wolfiR]]

Romaxa, could you drive the build change into trunk, please?

Comment 21

[Wolfgang Rosenauer [:wolfiR]]

just opened bug 367829 to support building w/o MOZ_ENABLE_POSTSCRIPT

Comment 22

[Andrew Benton]

Current firefox trunk builds don't seem to be able to print across a network. I can print from this computer (it has the printer attached) but I can't print from the computer downstairs (it hangs at the Preparing... screen and has to be killed). I had to reinstall firefox-2.0 on that computer (it works as it should)