362476 - crash following printing [@ nsThebesDeviceContext::EndDocument a37d4105]

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Bill Gianopoulos [:WG9s]]

Comment 1

[Bill Gianopoulos [:WG9s]]

Build-id: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061130 GranParadiso/3.0a1 ID:2006113020 [cairo]

For the last couple of days, Firefox crashes for me immediately after sending files to the printer.

Talkback: TB26742844Z

Comment 2

[Bill Gianopoulos [:WG9s]]

Another talkback id.  This one looks a bit different.

TB26702955G

Comment 3

[Peter van der Woude [:Peter6]]

Incident ID: 26742844
Stack Signature	nsThebesDeviceContext::EndDocument a37d4105
Product ID	FirefoxTrunk
Build ID	2006113020
Trigger Time	2006-12-01 06:14:05.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (00113fb5)
URL visited	
User Comments	Crashes immediately after completeing pring a webpage
Since Last Crash	27 sec
Total Uptime	8433 sec
Trigger Reason	Access violation
Source File, Line No.	e:\builds\tinderbox\fx-mozilla1.9-release\winnt_5.2_depend\mozilla\gfx\src\thebes\nsthebesdevicecontext.cpp, line 616
Stack Trace 	
nsThebesDeviceContext::EndDocument   nsPrintEngine::Destroy   nsPrintCompletionEvent::Run   NS_ProcessNextEvent_P   nsBaseAppShell::Run   0x003d4024
0xccccc3c0

Incident ID: 26702955
Stack Signature	0x85000402 5c7149fa
Product ID	FirefoxTrunk
Build ID	2006113004
Trigger Time	2006-11-30 08:35:43.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	
URL visited	
User Comments	
Since Last Crash	4246 sec
Total Uptime	4246 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
0x85000402
nsThebesDeviceContext::EndDocument  [mozilla\gfx\src\thebes\nsthebesdevicecontext.cpp, line 617]
nsPrintEngine::Destroy  [mozilla\layout\printing\nsprintengine.cpp, line 270]
nsPrintCompletionEvent::Run  [mozilla\layout\printing\nsprintengine.cpp, line 3714]
NS_ProcessNextEvent_P  [mozilla\xpcom\build\nsthreadutils.cpp, line 225]
nsBaseAppShell::Run  [mozilla\widget\src\xpwidgets\nsbaseappshell.cpp, line 153]
0x003d4024
0xccccc3c0

Comment 4

[Bill Gianopoulos [:WG9s]]

Regressed between Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061129 Minefield/3.0a1 ID:2006112904 [cairo] and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061129 Minefield/3.0a1 ID:2006113004 [cairo]

Checkins during this period

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=AviaryBranchTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-29+04%3A22%3A00&maxdate=2006-11-30+04%3A23%3A00&cvsroot=%2Fcvsroot

Looks like bug 323928.

Comment 5

[Bill Gianopoulos [:WG9s]]

Attachment: shot in the dark

I have no idea if this is the right fix (I suspect it isn't).

However, it does avoid the crash for me.

Comment 6

[Frederic Bezies]

Seeing this crash under linux ubuntu edgy eft, homemade build.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/2006120215 Firefox/3.0a1

Comment 7

[Stuart Parmenter]

Attachment: fix

Comment 8

[Stuart Parmenter]

what crash are you seeing on linux? this bug on windows (and mac) is due to an uninitalized pointer on everything _but_ linux.

Comment 9

[Frederic Bezies]

Simple to reproduce. Go to gmail, select print page, and try to print using only 1 page.

After preparing the print process, firefox "commits suicide" instead of printing. I can make it with an one hour old homemade trunk build under Ubuntu Edgy Eft and code up-to-date at midnight, mozilla.org time.

Comment 10

[Bill Gianopoulos [:WG9s]]

(In reply to comment #9)
> Simple to reproduce. Go to gmail, select print page, and try to print using
> only 1 page.
> 
> After preparing the print process, firefox "commits suicide" instead of
> printing. I can make it with an one hour old homemade trunk build under Ubuntu
> Edgy Eft and code up-to-date at midnight, mozilla.org time.
> 
That does not sound like the same bug.  Under windows at least, I get the full printout.

This crash could occur under Linux, if you are doing a non-gtk2 build for some reason, and the symptoms under Linux could be different, but in either case this patch should have fixed it, if it is the same bug.

Comment 11

[Frederic Bezies]

It is a cairo-gtk2 enabled build. So I don't understand why it is still crashing. My profile maybe ?!

Anyway, thanks for the infos.

Comment 12

[Bill Gianopoulos [:WG9s]]

I have verified that this no longer crashes for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061204 Minefield/3.0a1 ID:2006120404 [cairo].

What needs to be done to get this patch into the 1.9a1 preview build assuming it is not too late for that?  My guess is that it is probably not desirable to have that build crashing when you print.

Comment 13

[Adam Guthrie]

Marking as VERIFIED based on Bill's comments. As for getting this into the 1.9a1 release, I really don't see that happening. An alpha is going to have things busted, and we'll be shipping another one soon.

Frederic, please file a separate bug with steps to reproduce and a stacktrace, if you can get one. See http://kb.mozillazine.org/Getting_a_stacktrace_with_gdb for more info. on that.

Comment 14

[Stuart Parmenter]

we respun the alpha with this fix