Closed
Bug 324058
Opened 20 years ago
Closed 20 years ago
Fix nsStringStream compilation warning about multiple SetData versions
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file)
|
7.42 KB,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Fix nsStringStream compilation warning about multiple SetData versions.
Solution:
* Eliminate nsIStringInputStream2
* Implement nsISupportsCString instead
* Implement nsIClassInfo
The result, JS code can use "@mozilla.org/io/string-input-stream;1" without explicitly QI'ing the object. It'll be possible to do the following:
var s = Cc["@mozilla.org/io/string-input-stream;1"].createInstance();
s.data = "hello world";
channel.setUploadStream(s, "text/plain", -1);
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #209012 -
Flags: superreview?(bzbarsky)
Attachment #209012 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Comment 2•20 years ago
|
||
We should probably do something like this for file streams as well.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
|
||
Comment 3•20 years ago
|
||
Comment on attachment 209012 [details] [diff] [review]
v1 patch
oh, this is a nice solution.
Attachment #209012 -
Flags: review?(cbiesinger) → review+
|
||
Comment 4•20 years ago
|
||
Comment on attachment 209012 [details] [diff] [review]
v1 patch
I like!
Attachment #209012 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 5•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•