324058 - Fix nsStringStream compilation warning about multiple SetData versions

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Darin Fisher]

Fix nsStringStream compilation warning about multiple SetData versions.

Solution:
 * Eliminate nsIStringInputStream2
 * Implement nsISupportsCString instead
 * Implement nsIClassInfo

The result, JS code can use "@mozilla.org/io/string-input-stream;1" without explicitly QI'ing the object.  It'll be possible to do the following:

  var s = Cc["@mozilla.org/io/string-input-stream;1"].createInstance();
  s.data = "hello world";
  channel.setUploadStream(s, "text/plain", -1);

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

We should probably do something like this for file streams as well.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 209012 [details] [diff] [review]
v1 patch

oh, this is a nice solution.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 209012 [details] [diff] [review]
v1 patch

I like!

Comment 5

[Darin Fisher]

fixed-on-trunk