602724 - Remove setData from nsIStringInputStream.idl

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect)

Description

[Jason Duell]

Biesi thinks we should be able to get rid of 'setData' in nsIStringInputStream.idl.  The 'data' member in nsISupportsCString should be used instead, and supports all the functionality needed (plus handling null bytes).

Should be a matter of just replacing all uses of setData with ".data = " (the magic from bug 324058 makes .data available w/o needing a QI to nsISupportsCString), then we can remove from the IDL.

Comment 1

[[e-mail]]

We can't change it for 4, it's a bit late for that :(

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

As I mention in the see-also'ed bug 1182750, https://phabricator.services.mozilla.com/D231982 as part of bug 1935714 cleaned up nsIStringInputStream. Notably at this point there are both setByteStringData and setUTF8Data and they provide important guidance in their comments about UTF-8 handling that is not really provided on nsISupportsPrimitive (although it does say ASCII, I guess). I feel the motivating concern for this bug is gone and it's arguably better for someone using nsIStringInputStream for stream purposes to stick to the stream interfaces so I'm going to resolve this incomplete.