324095 - configure test should test pango version

Status: RESOLVED DUPLICATE of bug 328292

(Core :: Graphics, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I configured on a system that has pango 1.1.1 and it worked fine... then the build died with:

gfxPangoFonts.cpp
../../../../mozilla/gfx/thebes/src/gfxPangoFonts.cpp: In member function 
   `virtual const gfxFont::Metrics& gfxPangoFont::GetMetrics()':
../../../../mozilla/gfx/thebes/src/gfxPangoFonts.cpp:386: `PangoFcFont' 
   undeclared (first use this function)
../../../../mozilla/gfx/thebes/src/gfxPangoFonts.cpp:386: (Each undeclared 
   identifier is reported only once for each function it appears in.)
../../../../mozilla/gfx/thebes/src/gfxPangoFonts.cpp:386: `fcfont' undeclared 
   (first use this function)
../../../../mozilla/gfx/thebes/src/gfxPangoFonts.cpp:386: `PANGO_FC_FONT' 
   undeclared (first use this function)

Would be nice to have configure catch this up front.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/configure.in#4515 does have version checks...

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It does, but I'm guessing you're building with --enable-xft (or maybe without either, and we still default to --enable-xft, I think).  You need to build with --enable-pango and not --enable-xft -- I need to make configure bail if --enable-xft is specified with a cairo-gtk2 build and make --enable-pango the default.

Comment 3

[Steffen Wilberg]

XFT is enabled when $MOZ_ENABLE_GTK2 is true:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/configure.in&rev=1.1616&mark=4606-4608#4603
And that is true with cairo-gtk2 as well.

I guess I have to --disable-xft when I want to --enable-pango?

Oh, and my xft-not-pango build fails like this:
nsBrowserApp.cpp
../../dist/bin/libthebes.so: undefined reference to `pango_xft_font_get_font'
../../dist/bin/libthebes.so: undefined reference to `pango_xft_get_context'
collect2: ld returned 1 exit status
make[5]: *** [firefox-bin] Fehler 1
make[4]: *** [libs] Fehler 2
make[3]: *** [libs_tier_99] Fehler 2
make[2]: *** [tier_99] Fehler 2
make[1]: *** [default] Fehler 2
make: *** [build] Fehler 2

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> XFT is enabled when $MOZ_ENABLE_GTK2 is true:
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/configure.in&rev=1.1616&mark=4606-4608#4603
> And that is true with cairo-gtk2 as well.
> 
> I guess I have to --disable-xft when I want to --enable-pango?
> 

Sorry, my confusion; yes, --enable-xft is assumed with gtk2, with cairo you need --enable-pango as well.  --enable-xft only checks for pango 1.1.0, --enable-pango checks for pango 1.6.0, which is what's required.
The right check is in bug 328292 (to always require/assume --enable-pango in a cairo-gtk2 build), so gonna dup this against that.


*** This bug has been marked as a duplicate of 328292 ***