324173 - Viewer No Longer Builds on the 1.8 Branch (jsint)

Status: RESOLVED INVALID

(Core Graveyard :: Viewer App, defect)

Description

[Scott MacGregor]

If you build with tests enabled (which builds the viewer app), it no longer builds on the 1.8 branch. It does build on the trunk though.

Here is the error davel and I see:

/cygdrive/c/build/trees/1.5fxdbg/mozilla/webshell/tests/viewer/JSConsole.cpp
JSConsole.cpp
../../../dist/include/js\jspubtd.h(52) : error C2146: syntax error : missing ';'
 before identifier 'jsint'
../../../dist/include/js\jspubtd.h(52) : fatal error C1004: unexpected end of fi
le found
make: *** [JSConsole.obj] Error 2

Comment 1

[Benjamin Smedberg]

Is this due to a change in compiler or a change in code? It is unlikely that we can/want to support building the 1.8 branch with MSVC8.

Comment 2

[Dave Liebreich [:davel]]

I'm using VC6 on my build box.

Comment 3

[Scott MacGregor]

VC6.0 here as well.

Comment 4

[jon k.]

I got the same error. How can I continue the compilation process to compile TestGtkEmbed ?

Comment 5

[Venkat]

I'm also getting the same error. Did anyone find solution to this error ?

Comment 6

[jon k.]

I changed 2 header files to get the compilation to continue. In /dist/include/js/jspubtd.h and /dist/include/js/jsapi.h, any reference to int32 gives a "missing ';' before identifier 'jsint'" error message. To circumvent that, I changed int32 to uint32. Probably a bad thing to do, but anyway...

What you need to do is to modify jspubtd.h (52) first. Then carry on with the compilation to see the next error message and modify the next. I made 4 modifications in total.

Comment 7

[Bob Clary [:bc] (inactive)]

I just saw this error on 1.5/vc6 after attempting to switch from building in a DOS command shell to building in a cygwin shell.

Comment 8

[jeduden]

I suggest to use __int32 to make a quick-fix of this problem. 
uint32 changes the type from signed to unsigned that could lead to problems.

Comment 9

[Dmitry Dartz]

Patch is really simple, just change order of headers in JSConsole.cpp:

@@ -38,15 +38,15 @@
 //is case this is defined from the outside... MMP
 #ifdef WIN32_LEAN_AND_MEAN
 #undef WIN32_LEAN_AND_MEAN
 #endif
 
+#include "jsapi.h"
 #include "JSConsole.h"
 #include "jsconsres.h"
 #include "nsIScriptContext.h"
 #include <stdio.h>
-#include "jsapi.h"
 #include "nsReadableUtils.h"
 
 HINSTANCE JSConsole::sAppInstance = 0;
 HACCEL JSConsole::sAccelTable = 0;
 CHAR JSConsole::sDefaultCaption[] = "JavaScript Console";

Comment 10

[JP Rosevear [:jpr]]

Viewer was removed in bug 121881.