121881 - remove viewer

Status: RESOLVED FIXED

(Core Graveyard :: Viewer App, defect, P2)

Description

[Christopher Blizzard (:blizzard)]

It would be really nice to get rid of viewer if possible.  We could get rid of a
lot of the native widgets, remove a lot of glue code that iirc is only required
for viewer.  We need to figure out how to move the tests and whatnot into the
embedding tests, though, maybe through some common library?

Anyway, here's what waterson said in bug 91490:

Seriously tho, if you want kill viewer, then we'll need to:

  - rewrite the layout regression test harness
  - add the `dump [content|frames|views|style-contexts]' functionality
    to some other app.

Not rocket science, but probably takes some doin'. Oh, and this stuff would need
to work on Mac and Win32, too.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Running the regression tests in the layout debugger should work now, so I don't
think we have any need for viewer anymore.  (The embedding demo app for your
platform should handle debugging needs, and the layout debugger, i.e.,
extensions/layout-debug and "mozilla -layoutdebug", should handle the stuff in
viewer's menus.)

Instructions on running regression tests in the layout debugger:
 1. Have a debug build with --enable-extensions=default,layout-debug or just:
     cd mozilla/extensions
     make makefiles DIRS=layout-debug
     cd layout-debug
     make
 2. Run ./mozilla -layoutdebug
 3. [You only need to do this once; it's then saved in your profile.]
    Go to Regression Test -> Add New List..., and pick
    mozilla/layout/html/tests/block/rtest.lst
 4. Choose that list in the Regression Test -> Run Baseline or Regression Test
    -> Run Verify menus as appropriate.

When removing viewer, I'd like to remove:
  webshell/tests/*
  layout/html/tests/.../file_list.txt (all such files, after replacing with
    rtest.lst where that's not done already)
  layout/html/tests/.../{rtest.sh,rtest.bat,runtests.sh} (all such files)

Assigning to myself and targetting to Mozilla 1.7b.  Hopefully anyone who wants
to object will do so in the next few weeks.

Comment 2

[Roland Mainz]

dbaron:
Can I still do print regression tests with the "new" viewer app., esp. using the
crawler mode ?

Comment 3

[Christopher Blizzard (:blizzard)]

Death of viewer?  I can't wait!

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We can also remove nsIDocumentViewer::CreateDocumentViewerUsing

Comment 5

[Benjamin Smedberg]

Attachment: Stop building viewer, rev. 1

And subsequently remove all of webshell/tests

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron.  Please make sure there's a followup bug on removing the now-unneeded native widget code from widget on platforms where it hasn't been migrated to the viewer directory.

Comment 7

[Benjamin Smedberg]

Fixed on trunk.

Comment 8

[Peter Weilbacher]

*** Bug 323451 has been marked as a duplicate of this bug. ***