Last Comment Bug 121881 - remove viewer
: remove viewer
Product: Core Graveyard
Classification: Graveyard
Component: Viewer App (show other bugs)
: Trunk
: x86 All
P2 normal (vote)
: mozilla1.9alpha1
Assigned To: Benjamin Smedberg [:bsmedberg]
: 17027 323451 (view as bug list)
Depends on: 137331
Blocks: 93467 108273 204304 326417
  Show dependency treegraph
Reported: 2002-01-25 11:06 PST by Christopher Blizzard (:blizzard)
Modified: 2008-07-31 01:15 PDT (History)
16 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Stop building viewer, rev. 1 (555 bytes, patch)
2006-02-01 13:57 PST, Benjamin Smedberg [:bsmedberg]
dbaron: review+
Details | Diff | Splinter Review

Description User image Christopher Blizzard (:blizzard) 2002-01-25 11:06:20 PST
It would be really nice to get rid of viewer if possible.  We could get rid of a
lot of the native widgets, remove a lot of glue code that iirc is only required
for viewer.  We need to figure out how to move the tests and whatnot into the
embedding tests, though, maybe through some common library?

Anyway, here's what waterson said in bug 91490:

Seriously tho, if you want kill viewer, then we'll need to:

  - rewrite the layout regression test harness
  - add the `dump [content|frames|views|style-contexts]' functionality
    to some other app.

Not rocket science, but probably takes some doin'. Oh, and this stuff would need
to work on Mac and Win32, too.
Comment 1 User image David Baron :dbaron: ⌚️UTC-8 2004-02-01 20:06:00 PST
Running the regression tests in the layout debugger should work now, so I don't
think we have any need for viewer anymore.  (The embedding demo app for your
platform should handle debugging needs, and the layout debugger, i.e.,
extensions/layout-debug and "mozilla -layoutdebug", should handle the stuff in
viewer's menus.)

Instructions on running regression tests in the layout debugger:
 1. Have a debug build with --enable-extensions=default,layout-debug or just:
     cd mozilla/extensions
     make makefiles DIRS=layout-debug
     cd layout-debug
 2. Run ./mozilla -layoutdebug
 3. [You only need to do this once; it's then saved in your profile.]
    Go to Regression Test -> Add New List..., and pick
 4. Choose that list in the Regression Test -> Run Baseline or Regression Test
    -> Run Verify menus as appropriate.

When removing viewer, I'd like to remove:
  layout/html/tests/.../file_list.txt (all such files, after replacing with
    rtest.lst where that's not done already)
  layout/html/tests/.../{,rtest.bat,} (all such files)

Assigning to myself and targetting to Mozilla 1.7b.  Hopefully anyone who wants
to object will do so in the next few weeks.
Comment 2 User image Roland Mainz 2004-02-01 20:10:21 PST
Can I still do print regression tests with the "new" viewer app., esp. using the
crawler mode ?
Comment 3 User image Christopher Blizzard (:blizzard) 2004-02-02 10:38:55 PST
Death of viewer?  I can't wait!
Comment 4 User image David Baron :dbaron: ⌚️UTC-8 2004-04-21 12:25:10 PDT
We can also remove nsIDocumentViewer::CreateDocumentViewerUsing
Comment 5 User image Benjamin Smedberg [:bsmedberg] 2006-02-01 13:57:06 PST
Created attachment 210398 [details] [diff] [review]
Stop building viewer, rev. 1

And subsequently remove all of webshell/tests
Comment 6 User image David Baron :dbaron: ⌚️UTC-8 2006-02-07 15:28:12 PST
r=dbaron.  Please make sure there's a followup bug on removing the now-unneeded native widget code from widget on platforms where it hasn't been migrated to the viewer directory.
Comment 7 User image Benjamin Smedberg [:bsmedberg] 2006-02-08 08:50:36 PST
Fixed on trunk.
Comment 8 User image Peter Weilbacher 2006-02-09 02:21:58 PST
*** Bug 323451 has been marked as a duplicate of this bug. ***
Comment 9 User image David Baron :dbaron: ⌚️UTC-8 2008-05-17 10:02:20 PDT
*** Bug 17027 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.