324665 - New events do not display in day/week view until refresh (Lightning only)

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stephan Schaefer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

After creating a new event in the week view you have to refresh the view in order to make the event visible.

Reproducible: Always

Steps to Reproduce:
1. Choose a local calendar and enter week view
2. Doubleclick and fill in a title and time in the visible range (eg 15-16)
3. Hit ok

Actual Results:  
The event does not show up, you have to switch views first.

Expected Results:  
The event should appear immediately.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Adding to the blocker list.  This is pretty basic functionality.

Comment 2

[Michael Büttner (no reviews TFN)]

taking resposibility for this...

Comment 3

[Michael Büttner (no reviews TFN)]

Attachment: patch for this bug

the problem is actually caused at http://lxr.mozilla.org/seamonkey/source/calendar/lightning/content/calendar-management.js#162
this line actually modifies the dates inside the week-view, which causes further calls to findColumnForDate() in calendar-multiweek-view.xml to fail. the solution to the problem is to return a copy of the date the selectedDay-property refers to.

Comment 4

[Michael Büttner (no reviews TFN)]

Attachment: new proposal

changed the patch as discussed on IRC. the getter for week-view::selectedDay does no longer clone the date as i previously proposed, instead the caller that messed around with it now clones the object.
as i noted this morning, the patch for bug #324028 was commited, which makes the problem incidentally disappear. the targetDate gets converted to a 'isDate'-compatible version of the original, but calendar-management.js still messes around with the internal data of the view, so this patch isn't obsolete.

Comment 5

[Joey Minta]

Comment on attachment 210566 [details] [diff] [review]
new proposal

Can you also do .makeImmutable() in the view's selectedDay getter(s) so that no more of these problems creep in unexpectedly?

Comment 6

[Michael Büttner (no reviews TFN)]

Attachment: new proposal

added .makeImmutable() appropriately

Comment 7

[Joey Minta]

Comment on attachment 210863 [details] [diff] [review]
new proposal

r=jminta Thanks for your patience on this patch.

Comment 8

[Joey Minta]

Patch checked in.  Let's keep an eye out to see if that makeImmutable() unearths any other problems.