Closed Bug 324735 Opened 14 years ago Closed 14 years ago

Reference to obsolete object calIItemOccurence in calICalendar.idl

Categories

(Calendar :: Internal Components, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: reidrankin, Unassigned)

Details

Attachments

(2 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Sunbird 0.3a

I was writing an extension and had the hardest time finding the calIItem
Occurance interface-which didn't exist, but is referenced in the calICalendar.idl file on line 114. This should be removed.

Reproducible: Always

Steps to Reproduce:
http://landfill.mozilla.org/mxr-test/mozilla/search?string=caliitemoccur&find=&filter=
Status: UNCONFIRMED → NEW
Component: General → Base
Ever confirmed: true
Summary: Reference to osbolete object calIItemOccurence in calICalendar.idl → Reference to obsolete object calIItemOccurence in calICalendar.idl
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #209713 - Flags: first-review?(jminta)
Comment on attachment 209713 [details] [diff] [review]
Patch v1

-
-  /**
-   * Return an array of calIItemOccurrence representing all
-   * occurrences of this event between start (inclusive) and end (non-inclusive).
-   */
-  void getOccurrences (in calIDateTime aRangeStart,
-                       in calIDateTime aRangeEnd,
-                       in unsigned long aMaxCount,
-                       out unsigned long aCount, [array,size_is(aCount),retval] out calIItemBase aItems);

The only problem here is the comment, the function looks ok (it doesn't involve the interface in its in/out params.

-  /**
-   * Modify aOccurrence.  If aNewStartTime and aNewEndTime are given,
-   * update the event to those times.  Otherwise ask the user to modify.
-   */
-  void modifyOccurrence (in calIItemOccurrence aOccurrence,
-			 in calIDateTime aNewStartTime,
-			 in calIDateTime aNewEndTime);
-
-  /**
-   * Delete the given event.  This should prompt whether to delete
-   * just this occurrence or all occurrences, and do whatever else
-   * is appropriate.
-   */
-  void deleteOccurrence (in calIItemOccurrence aOccurrence);

eep! We need all those functions, a lot.  We just need them to be using calIItemBase, not calIItemOccurrence.
Attachment #209713 - Flags: first-review?(jminta) → first-review-
Attached patch Patch v2 (obsolete) — Splinter Review
This should fix everything except http://landfill.mozilla.org/mxr-test/mozilla/source/calendar/base/public/calICalendar.idl#114
Attachment #209713 - Attachment is obsolete: true
Attachment #209719 - Flags: first-review?(jminta)
Comment on attachment 209719 [details] [diff] [review]
Patch v2

Disregard, sorry, that's not how it's supposed to be done, my build failed.
Attachment #209719 - Attachment is obsolete: true
Attachment #209719 - Flags: first-review?(jminta)
Attached patch Patch v3Splinter Review
This patch has gone through some testing. Compared to the latest trunk build, and it works just as good =) Sorry for the lack of testing in the two earlier patches.
Attachment #209741 - Flags: first-review?(jminta)
Comment on attachment 209741 [details] [diff] [review]
Patch v3

Nice job! r=jminta
Attachment #209741 - Flags: first-review?(jminta) → first-review+
"Patch v3" checked in.  Leaving bug open for further work.  Can someone please also fix http://developer.mozilla.org/en/docs/Interfaces ? Thanks.
(In reply to comment #8)
> "Patch v3" checked in.  Leaving bug open for further work.  Can someone please
> also fix http://developer.mozilla.org/en/docs/Interfaces ? Thanks.
> 

calIItemOccurence removed from http://developer.mozilla.org/en/docs/Interfaces

Attached patch update last docSplinter Review
This is the last doc that didn't get updated.
Attachment #211347 - Flags: first-review?(mvl)
Comment on attachment 211347 [details] [diff] [review]
update last doc

r=mvl
Attachment #211347 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!
QA Contact: general → base
You need to log in before you can comment on or make changes to this bug.