324866 - Tree Widgets Are Not Painting Correctly (Fx and Tb)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Scott MacGregor]

Regression that happened sometime yesterday. In the 01/26 builds, the thunderbird tree widgets are no longer painting there contents correctly.

Could it be related to Bug 317375 which did touch the tree frame code yesterday?

Screen shot coming up

Comment 1

[Scott MacGregor]

Attachment: screen shot, I circled in red the problem area

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

duplicate of bug 324836 (which has just been fixed on trunk)?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

hmm, no, probably not. What's the simplest place this appears? anywhere in Firefox? Guess I'll spin up a Thunderbird build

Comment 4

[Scott MacGregor]

I just updated layout\generic\nsFrame.cpp and rebuilt layout, but the problem appears to still be there. Shucks.

Comment 5

[Scott MacGregor]

This might just be noise, but if I drag the columns somewhere else (like over to the left near the subject, they start painting fine. But anything after the sender column fails to paint.

Comment 6

[Scott MacGregor]

Hey Roc, I can reproduce this in todays Firefox build too.

Just got to the bookmark manager.

You might need to add some extra tree columns to the bookmarks tree. I see lots of blank columns on the right most tree cols. 

And I just noticed that if I move the vertical splitter to the left and to the right in this window, I see some of the items get painted. I tried this in Thunderbird and saw the same thing. Resizing the splitter, triggered some level of painting to happen on these tree columns.

I hope that helps.

Comment 7

[Scott MacGregor]

Its even easier now. Just take the bookmarks manager as is, and move the splitter to the right, you should see the bookmarks tree stop getting painted.

Comment 8

[Scott MacGregor]

adjusting the summary since this applies to Firefox and Thunderbird.

And moving the component.

Comment 9

[Pavel Franc - Mozilla.cz]

(In reply to comment #5)
> This might just be noise, but if I drag the columns somewhere else (like over
> to the left near the subject, they start painting fine. But anything after the
> sender column fails to paint.

I experienced this behaviour two years ago in AddressBook - bug 251079. It looks like you summoned it back ;)

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This fixes it for me. OffsetForHorzScroll expects cellrect to be in frame coordinates. We need to adjust the x coordinate to rendering coordinates after OffsetForHorzScroll but before PaintCell. This is now consistent with the code around the PaintCell call earlier in the code.

Comment 11

[Scott MacGregor]

restoring fields lost due to bug stompage.

Comment 12

[Scott MacGregor]

This patch does indeed fix the problem for me in thunderbird. I didn't test it in Firefox. Thanks roc!

Comment 13

[Edward]

*** Bug 324873 has been marked as a duplicate of this bug. ***

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 15

[Philip Puryear]

*** Bug 324881 has been marked as a duplicate of this bug. ***

Comment 16

[Veritas]

*** Bug 324905 has been marked as a duplicate of this bug. ***

Comment 17

[james davis]

*** Bug 324930 has been marked as a duplicate of this bug. ***