324836 - Listboxes are broken because they're not treated as pseudo-stacking-contexts

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

My patch in bug 317375 broke listboxes because they're not being treated as pseudo-stacking-contexts as intended. Options don't receive events because their backgrounds are placed under the <select> background.

Comment 1

[Steve England [:stevee]]

*** Bug 324834 has been marked as a duplicate of this bug. ***

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

I'm not aware of any internal API we have to say "this frame acts like a block internally". IsContainingBlock is close, but it doesn't include scrollframes or frames derived from scrollframes. In the absence of such an API (IsFrameOfType?) I'm going to have to hack it ... e.g., setting IsContainingBlock() for scrollframes is too risky for a quick fix, I've really tried hard not to disturb layout behaviour.

I don't think you can have inline regular scrollframes currently, so I'm not testing for those. We'll need it for overflow:auto inline-blocks but hopefully this will be replaced with a real API by then.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

*** Bug 324812 has been marked as a duplicate of this bug. ***

Comment 4

[Dave Townsend [:mossop]]

*** Bug 324806 has been marked as a duplicate of this bug. ***

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

fix checked in

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060126 Firefox/1.6a1 ID:2006012613

verified on windows

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

/layout/generic/nsIFrame.h, line 1147 -- virtual PRBool IsFrameOfType(PRUint32 aFlags) const

does that comment need an update? :)

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Not sure what you mean.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 324908 has been marked as a duplicate of this bug. ***

Comment 10

[Steve England [:stevee]]

*** Bug 324932 has been marked as a duplicate of this bug. ***

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

your comment in the patch says that IsFrameOfType would be nice, I'm saying it exists.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's not really implemented yet.