324892 - restore cairo/Thebes opacity handling

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Frame display lists reverted Thebes to using the backbuffer/alpha recovery code for 'opacity'. It's easy to fix it back to use the PushFilter/PopFilter nsIRenderingContext API that Thebes supports.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: untested patch

I don't have time to test this in a Thebes build right now, and I'm leaving town for a few days, but it's simple enough to work.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Is this the same issue as bug 324561 ?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

*** Bug 324561 has been marked as a duplicate of this bug. ***

Comment 4

[Samuel Sidler (old account; do not CC)]

I assume this is the same issue as bug 325296 as well?

Comment 5

[Stuart Parmenter]

(In reply to comment #4)
> I assume this is the same issue as bug 325296 as well?
> 

Should be completely unrelated.  This code path that broke was cairo/thebes builds only.

Comment 6

[Stuart Parmenter]

Comment on attachment 209797 [details] [diff] [review]
untested patch

this patch fixes some of it, but not all. there are still lots of clipping bugs and such with this patch.

Comment 7

[Brian Polidoro]

Well something has changed in today's build.  The inactive tab's close buttons now appear.  (duped bug 324561 above)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060131 Firefox/1.6a1 ID:2006013104

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #6)
> (From update of attachment 209797 [details] [diff] [review] [edit])
> this patch fixes some of it, but not all. there are still lots of clipping bugs
> and such with this patch.

Does the Thebes PushFilter path actually apply the current clip rect?

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The clipping bugs are probably unrelated to this patch; it shouldn't have been -'d.  There may be some extra work involved -- I'm looking at it now.

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The patch in bug 326471 fixes this.

Comment 11

[chris hofmann]

bug 326471 has been fixed.  should this be closed now?

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

yes