restore cairo/Thebes opacity handling

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Frame display lists reverted Thebes to using the backbuffer/alpha recovery code for 'opacity'. It's easy to fix it back to use the PushFilter/PopFilter nsIRenderingContext API that Thebes supports.
I don't have time to test this in a Thebes build right now, and I'm leaving town for a few days, but it's simple enough to work.
Is this the same issue as bug 324561 ?
*** Bug 324561 has been marked as a duplicate of this bug. ***
I assume this is the same issue as bug 325296 as well?

Comment 5

14 years ago
(In reply to comment #4)
> I assume this is the same issue as bug 325296 as well?
> 

Should be completely unrelated.  This code path that broke was cairo/thebes builds only.

Comment 6

14 years ago
Comment on attachment 209797 [details] [diff] [review]
untested patch

this patch fixes some of it, but not all. there are still lots of clipping bugs and such with this patch.
Attachment #209797 - Flags: review-

Comment 7

14 years ago
Well something has changed in today's build.  The inactive tab's close buttons now appear.  (duped bug 324561 above)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060131 Firefox/1.6a1 ID:2006013104
(In reply to comment #6)
> (From update of attachment 209797 [details] [diff] [review] [edit])
> this patch fixes some of it, but not all. there are still lots of clipping bugs
> and such with this patch.

Does the Thebes PushFilter path actually apply the current clip rect?
The clipping bugs are probably unrelated to this patch; it shouldn't have been -'d.  There may be some extra work involved -- I'm looking at it now.
The patch in bug 326471 fixes this.
No longer blocks: 317375
Depends on: 326471

Updated

13 years ago
Depends on: 334512

Updated

13 years ago
Blocks: 334512
No longer depends on: 334512
Blocks: 334737
No longer blocks: 334512

Comment 11

13 years ago
bug 326471 has been fixed.  should this be closed now?
yes
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.