Closed Bug 326074 Opened 20 years ago Closed 20 years ago

Edit event via middle/right double click possible (again)

Categories

(Calendar :: Sunbird Only, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: jminta)

Details

(Keywords: regression)

Attachments

(1 file)

Edit event via middle/right double click possible (again) in day/week view. In mozilla/calendar/base/content/calendar-multiday-view.xml we react only on double clicks via left mouse button using <handler event="dblclick" button="0"> xbl event handler. This worked before. In the latest build this is not honored anymore. You can use left/middle/right double click to edit event. WORKS: Sunbird 0.3a1+ win32-2006-02-04-06-trunk build (day/week view) FAILS: Sunbird 0.3a1+ win32-2006-02-05-12-trunk build (day/week view) (In multiweek/month view middle/right double click opens the edit event dialog too. But in this case it was never limited to left mouse button. Should file a bug to fix that too.)
The original version of this patch was put together by ssitter on Bug 323321. The problem was that I made my 'make items inherit from a base class' patch before that patch landed, and then had to manually merge, due to conflicts, when it was time to check in. ssitter's patch got lost in that merge. This patch brings the changes back, placing them in the new, appropriate location.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #211227 - Flags: first-review?(dmose)
(In reply to comment #0) > (In multiweek/month view middle/right double click opens the edit event dialog > too. But in this case it was never limited to left mouse button. Should file a > bug to fix that too.) I was just about filing a new bug (Multiweek/month view: don't start inline editing on middle/right mouse click) but than I realized that this patch to calendar-view-core.xml should fix this too.
Comment on attachment 211227 [details] [diff] [review] port ssitter's patch r=mvl
Attachment #211227 - Flags: first-review?(dmose) → first-review+
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060909 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: