326116 - Check etag when downloading

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

Should check the etag when downloading, so that we can detect if there have been any remote changes. If there were no changes, we can skip the parsing step.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

patch should do the trick.
It will be a performance improvement on refresh, and is needed for doing timed reload, te keep some performance.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v2 updated to not conflict with the trunk

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 214110 [details] [diff] [review]
patch, v2 updated to not conflict with the trunk

>     onStreamComplete: function(loader, ctxt, status, resultLength, result)
>     {
>         // Allow the hook to get needed data (like an etag) of the channel
>-        this.mHooks.onAfterGet();
>+        var cont = this.mHooks.onAfterGet();
>+        if (!cont)
>+            return;

If we just return like this, won't we fail to call onLoad(), set the locked attribute, and process the queue?

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v3, updated to review comment

I created an unlock function, that does the cleanup. Also moved the check for the empty string somewhat earlier in the function.
For symmetry, added a lock and isLocked function.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 214115 [details] [diff] [review]
patch v3, updated to review comment

r=dmose with s/cleanupLoading/unlock//.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Updated version of v3 patch landed; thanks for the patch, Michiel!