326332 - Event creation in ics calendar fails after backup problems.

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Event creation in ics calendar fails after backup problems.

1. Start Sunbird with a new profile.
2. Delete the default storage calendar.
3. Create an ics calendar (I tested with a remote calendar at file:///c:/test.ics)
4. Create an event via drag'n'drop in week view. The following error appeared in console:

Backup failed in asyncOpen:[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIChannel.asyncOpen]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///D:/Programme/sunbird/components/calICSCalendar.js :: anonymous :: line 683"  data: no]

5. Create more events. 
In %SunbirdProfile%\backupData backup files are created named calBackupData_xxxx_edit-1.ics to calBackupData_xxxx_edit-3.ics. After creation of the next event the following error is shown four times in JavaScript console:

Error: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///D:/Programme/sunbird/components/calICSCalendar.js :: purgeBackupsByType :: line 548"  data: no]

Afterwards it is not possible to create new events. Restart of Sunbird required.

Tested on windows with 2006-02-07 sunbird trunk build.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I've seen at least the access denied thing not too long ago; confirming.

Comment 2

[Joey Minta]

Is this still a bug?  I can't reproduce on linux using comment #0.

Comment 3

[Stefan Sitter [:ssitter]]

(In reply to comment #2)
I can still reproduce using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060713 Sunbird/0.3a2+.

Error: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///D:/sunbird/components/calICSCalendar.js :: purgeBackupsByType :: line 620"  data: no]

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

I typically have to restart Sunbird on Windows and Mac on the order of 10 times a day.  This generally happens I edit multiple events in quick successionon a WebDAV  calendar.  There are really two bugs here: one is probably in nsLocalFile* and the other is that we should catch any errors thrown by nsLocalFile* and do something reasonable. I believe the bug in nsLocalFile is already filed.

Comment 6

[Joey Minta]

Attachment: maybe patch

I still can't reproduce this bug, so this is just a best-guess at a patch.  The idea here is that failing to remove a file is the least severe kind of error we can have.  (When were more backups not a good thing?)  Also, we'll eventually get to clear it up, on the next round of backups.

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 233028 [details] [diff] [review]
maybe patch

This at least catches the failure. That's good.

Should we at least send this to the error console rather than swallowing it entirely?

Comment 8

[Joey Minta]

(In reply to comment #7)
> (From update of attachment 233028 [details] [diff] [review] [edit])
> This at least catches the failure. That's good.
> 
> Should we at least send this to the error console rather than swallowing it
> entirely?
> 
As I said in my comment, this strikes me as one of the absolutely least critical failure modes imaginable.  At best, I think we should dump it to the regular console.  I'm open to arguments why that's wrong.

Comment 9

[Matthew (lilmatt) Willis]

Comment on attachment 233028 [details] [diff] [review]
maybe patch

Okay. I don't think this will hurt anything, and if it keeps people from having to restart, then it's at least forward progress.

r=lilmatt

Comment 10

[Joey Minta]

Comment on attachment 233028 [details] [diff] [review]
maybe patch

r=dmose

Comment 11

[Joey Minta]

Patch checked in.  I'm marking this fixed since it's on the blocking radar.  If there are other problems, please file followups.  Let's reserve this bug for backup-errors of the severity listed here.

Comment 12

[Stefan Sitter [:ssitter]]

VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060901 Calendar/0.3a2+