326417 - Remove native widget code hacks needed only by viewer

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Benjamin Smedberg]

From bug 121881 comment 6: there are various hacks in native widget code that are needed only for viewer, which is dead. These hacks should be removed.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I haven't yet tested this, and it's probably not worth testing it to excess; something will go red, and I'll fix it.  But I do plan to do a GTK2 build before requesting review.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And this will be followed up by CVS removal of all files removed from the makefiles, plus the corresponding .h files, plus the corresponding files in widget/src/mac/ that have already been removed from makefiles and ifdef-ed out.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #2)
> plus the corresponding files in
> widget/src/mac/ that have already been removed from makefiles and ifdef-ed out.

Er, no, they're already removed from the tree, just not completely removed from the source.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To fix bustage I had to remove some code from widget/src/gtk/nsGtkEventHandler.cpp and widget/src/gtk/nsGtkEventHandler.h that was only used by the removed file widget/src/gtk/nsTextWidget.cpp .

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And I found a random
#include "nsIButton.h"
in nsView.cpp that needed to be removed (not sure why I didn't hit the bustage).

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hrm, I suppose it was because I didn't do a clobber build and the build system for some reason doesn't trigger a removed dependency as causing a rebuild...