326562 - No 'Visit URL' button in the new event dialog

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

The old Sunbird event-dialog had a 'Visit URL' button right next to the url field.  This has since been lost.

Patch to follow.

Comment 1

[Joey Minta]

Attachment: bring back button

There isn't much use in having a 'URL' field if you can't easily visit that url.  launchBrowser() is defined in applicationUtil.js, so that needs to get included in lightning for it to work there.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 211283 [details] [diff] [review]
bring back button

This will produce browser errors if the url field is empty and you press the button. The browser tries to load 'http://' and fails.

There should be either a check for url not empty after pressing the button or the button should be disabled if no url is entered in field.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 211283 [details] [diff] [review]
bring back button

minused, given Stefan's comment.  Also, can you attach a screenshot?

Comment 4

[Joey Minta]

Attachment: bring back button v2

version 2 includes error checking for blank URLs.  The Visit URL button will be disabled in that case.  The requested screenshot can be found here: http://www.nd.edu/~jminta/mozilla/Screenshot-1.png

Comment 5

[Joey Minta]

Significant regression in the event-dialog's capabilities.  Blocks 0.3a2

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 212382 [details] [diff] [review]
bring back button v2

r=dmose if you add |return|s to the end of the functions that you touched.  That makes it clear that the end of the function is intentional, and not that someone was inadvertantly distracted while writing the code.

Comment 7

[Joey Minta]

Patch checked in, with returns

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 212382 [details] [diff] [review]
bring back button v2

>@@ -810,16 +810,18 @@ function loadDetails() {
>     updateTaskAlarmWarnings();
>+
>+    updateURL();
> }
> 
...
>+
>+function updateURL(aValue) 
>+{
>+    var button = document.getElementById("load-url-button");
>+    button.setAttribute("disabled", true)
>+
>+    if (!aValue) {
>+        return;
>+    }

I did not notice until now: Because the call to updateURL() in loadDetails() does not pass in a url the button will be always disabled (even if the existing url is valid) when opening the dialog until you type something into the url field.

Comment 9

[Joey Minta]

Attachment: fix for ssitter's comment

Fix for ssitter's comment.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 216870 [details] [diff] [review]
fix for ssitter's comment

r=dmose

Comment 11

[Joey Minta]

followup patch checked in.

Comment 12

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060909 Calendar/0.3a2+