Remove xprint from the tree

RESOLVED FIXED in mozilla1.9alpha6

Status

Core Graveyard
Printing: Xprint
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Stuart Parmenter, Assigned: mats)

Tracking

Trunk
mozilla1.9alpha6
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Moving forward, we're no longer going to support xprint.  We're going to do PDF and PS output through CUPS on Unix platforms.

I just disabled xprint printing in gtk builds.  I suggest that we go ahead remove the configure options and remove it from the tree.
OS: Windows XP → Linux
Assignee: nobody → masaki.katakai
Component: GFX: Gtk → Printing: Xprint
QA Contact: gtk → roland.mainz

Comment 1

11 years ago
Taking. can I simply remove all xprint codes?
Status: NEW → ASSIGNED
(Reporter)

Comment 2

10 years ago
argh.  Don't know how I missed this comment so long ago.

We should go ahead and remove all that code.  Do you want to do it or should I?

Comment 3

10 years ago
Thank you for asking Pavlov. Could you take this bug and remove all xprint codes?
Assignee: masaki.katakai → pavlov
Status: ASSIGNED → NEW
(Assignee)

Updated

10 years ago
Assignee: pavlov → mats.palmgren
Summary: Disable xprint → Remove xprint from the tree
(Assignee)

Comment 4

10 years ago
Created attachment 263324 [details] [diff] [review]
Patch rev. 1 (this is without removed files)
Attachment #263324 - Flags: superreview?(dbaron)
Attachment #263324 - Flags: review?(dbaron)
(Assignee)

Comment 5

10 years ago
Created attachment 263325 [details]
List of removed files
Attachment #263325 - Flags: superreview?(dbaron)
Attachment #263325 - Flags: review?(dbaron)
Comment on attachment 263324 [details] [diff] [review]
Patch rev. 1 (this is without removed files)

In nsDeviceContextSpecG.cpp you're modifying a comment (detached from the code it was commenting on by the insertion of a cairo ifdef) rather than removing it.  Other than that, this looks fine, although I wouldn't be surprised if we find something else to remove later.  r+sr=dbaron

(Although for the gfx stuff vlad is probably a better reviewer...)
Attachment #263324 - Flags: superreview?(dbaron)
Attachment #263324 - Flags: superreview+
Attachment #263324 - Flags: review?(dbaron)
Attachment #263324 - Flags: review+
Attachment #263325 - Flags: superreview?(dbaron)
Attachment #263325 - Flags: superreview+
Attachment #263325 - Flags: review?(dbaron)
Attachment #263325 - Flags: review+
(Assignee)

Updated

10 years ago
Blocks: 376791
(Assignee)

Comment 7

10 years ago
Nit fixed (removed the comment).

Checked in on trunk at 2007-06-13 11:03 PDT.

-> FIXED
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
Product: Core → Core Graveyard

Updated

8 years ago
Blocks: 218096
You need to log in before you can comment on or make changes to this bug.