Moving forward, we're no longer going to support xprint. We're going to do PDF and PS output through CUPS on Unix platforms. I just disabled xprint printing in gtk builds. I suggest that we go ahead remove the configure options and remove it from the tree.
11 years ago
11 years ago
Taking. can I simply remove all xprint codes?
argh. Don't know how I missed this comment so long ago. We should go ahead and remove all that code. Do you want to do it or should I?
Thank you for asking Pavlov. Could you take this bug and remove all xprint codes?
Created attachment 263324 [details] [diff] [review] Patch rev. 1 (this is without removed files)
Created attachment 263325 [details] List of removed files
Comment on attachment 263324 [details] [diff] [review] Patch rev. 1 (this is without removed files) In nsDeviceContextSpecG.cpp you're modifying a comment (detached from the code it was commenting on by the insertion of a cairo ifdef) rather than removing it. Other than that, this looks fine, although I wouldn't be surprised if we find something else to remove later. r+sr=dbaron (Although for the gfx stuff vlad is probably a better reviewer...)
Nit fixed (removed the comment). Checked in on trunk at 2007-06-13 11:03 PDT. -> FIXED