Closed Bug 326716 Opened 15 years ago Closed 14 years ago

Remove xprint from the tree

Categories

(Core Graveyard :: Printing: Xprint, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: pavlov, Assigned: mats)

References

Details

Attachments

(2 files)

Moving forward, we're no longer going to support xprint.  We're going to do PDF and PS output through CUPS on Unix platforms.

I just disabled xprint printing in gtk builds.  I suggest that we go ahead remove the configure options and remove it from the tree.
OS: Windows XP → Linux
Assignee: nobody → masaki.katakai
Component: GFX: Gtk → Printing: Xprint
QA Contact: gtk → roland.mainz
Taking. can I simply remove all xprint codes?
Status: NEW → ASSIGNED
argh.  Don't know how I missed this comment so long ago.

We should go ahead and remove all that code.  Do you want to do it or should I?
Thank you for asking Pavlov. Could you take this bug and remove all xprint codes?
Assignee: masaki.katakai → pavlov
Status: ASSIGNED → NEW
Assignee: pavlov → mats.palmgren
Summary: Disable xprint → Remove xprint from the tree
Attachment #263324 - Flags: superreview?(dbaron)
Attachment #263324 - Flags: review?(dbaron)
Attached file List of removed files
Attachment #263325 - Flags: superreview?(dbaron)
Attachment #263325 - Flags: review?(dbaron)
Comment on attachment 263324 [details] [diff] [review]
Patch rev. 1 (this is without removed files)

In nsDeviceContextSpecG.cpp you're modifying a comment (detached from the code it was commenting on by the insertion of a cairo ifdef) rather than removing it.  Other than that, this looks fine, although I wouldn't be surprised if we find something else to remove later.  r+sr=dbaron

(Although for the gfx stuff vlad is probably a better reviewer...)
Attachment #263324 - Flags: superreview?(dbaron)
Attachment #263324 - Flags: superreview+
Attachment #263324 - Flags: review?(dbaron)
Attachment #263324 - Flags: review+
Attachment #263325 - Flags: superreview?(dbaron)
Attachment #263325 - Flags: superreview+
Attachment #263325 - Flags: review?(dbaron)
Attachment #263325 - Flags: review+
Blocks: 376791
Nit fixed (removed the comment).

Checked in on trunk at 2007-06-13 11:03 PDT.

-> FIXED
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
Product: Core → Core Graveyard
Blocks: 218096
You need to log in before you can comment on or make changes to this bug.