Closed
Bug 326716
Opened 19 years ago
Closed 17 years ago
Remove xprint from the tree
Categories
(Core Graveyard :: Printing: Xprint, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha6
People
(Reporter: pavlov, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(2 files)
70.51 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
668 bytes,
text/plain
|
dbaron
:
review+
dbaron
:
superreview+
|
Details |
Moving forward, we're no longer going to support xprint. We're going to do PDF and PS output through CUPS on Unix platforms.
I just disabled xprint printing in gtk builds. I suggest that we go ahead remove the configure options and remove it from the tree.
Updated•19 years ago
|
OS: Windows XP → Linux
Updated•19 years ago
|
Assignee: nobody → masaki.katakai
Component: GFX: Gtk → Printing: Xprint
QA Contact: gtk → roland.mainz
Reporter | ||
Comment 2•18 years ago
|
||
argh. Don't know how I missed this comment so long ago.
We should go ahead and remove all that code. Do you want to do it or should I?
Comment 3•18 years ago
|
||
Thank you for asking Pavlov. Could you take this bug and remove all xprint codes?
Assignee: masaki.katakai → pavlov
Status: ASSIGNED → NEW
Assignee | ||
Updated•18 years ago
|
Assignee: pavlov → mats.palmgren
Summary: Disable xprint → Remove xprint from the tree
Assignee | ||
Comment 4•18 years ago
|
||
Attachment #263324 -
Flags: superreview?(dbaron)
Attachment #263324 -
Flags: review?(dbaron)
Assignee | ||
Comment 5•18 years ago
|
||
Attachment #263325 -
Flags: superreview?(dbaron)
Attachment #263325 -
Flags: review?(dbaron)
Comment on attachment 263324 [details] [diff] [review]
Patch rev. 1 (this is without removed files)
In nsDeviceContextSpecG.cpp you're modifying a comment (detached from the code it was commenting on by the insertion of a cairo ifdef) rather than removing it. Other than that, this looks fine, although I wouldn't be surprised if we find something else to remove later. r+sr=dbaron
(Although for the gfx stuff vlad is probably a better reviewer...)
Attachment #263324 -
Flags: superreview?(dbaron)
Attachment #263324 -
Flags: superreview+
Attachment #263324 -
Flags: review?(dbaron)
Attachment #263324 -
Flags: review+
Attachment #263325 -
Flags: superreview?(dbaron)
Attachment #263325 -
Flags: superreview+
Attachment #263325 -
Flags: review?(dbaron)
Attachment #263325 -
Flags: review+
Assignee | ||
Comment 7•17 years ago
|
||
Nit fixed (removed the comment).
Checked in on trunk at 2007-06-13 11:03 PDT.
-> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha6
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•