Closed Bug 376791 Opened 13 years ago Closed 11 years ago
remove code for non-cairo GFX ports from tree
Now that non-cairo GFX ports no longer build, we should remove the code for them from the tree. Having them around can be very confusing for new contributors trying to learn or contribute to Mozilla's code, since they can end up looking at the wrong code. It's also just extra code that we don't need everybody to pull.
13 years ago
Depends on: 326152
Flags: blocking1.9? → blocking1.9-
13 years ago
Depends on: 378995
I think qt and photon are non-cairo: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/configure.in&rev=1.1805&root=/cvsroot&mark=4535-4542#4511 http://lxr.mozilla.org/mozilla/source/gfx/src/qt/ http://lxr.mozilla.org/mozilla/source/widget/src/qt/ http://lxr.mozilla.org/mozilla/source/gfx/src/photon/ http://lxr.mozilla.org/mozilla/source/widget/src/photon/ What's the plan for these two ports?
(In reply to comment #2) > I think qt and photon are non-cairo: > > What's the plan for these two ports? The QT and Photon ports are dead, and have been for a while.
I contacted Max Feil <email@example.com> and he says there is ongoing work to move the Photon port to cairo eventually. I have asked him to file a bug on this.
What is the status on this?
This bug is about removal of dead code; it shouldn't block any changes to currently used code.
As long as qt, photon, and may be others refer in the CVS tree to non-cairo code, the non-cairo code removal is "blocked". Especially because the status of qt, photon, etc are unclear. Note that the non-cairo builds will fail anyway, because in many areas (such image decoders don't do non-cairo anymore).
qt was removed in bug 380196. firstname.lastname@example.org said they will make the photon port use cairo at some point (bug 384057) and asked us to not remove the old photon code (gfx/widget) just yet because they wanted easy access to it while doing that work. I agree with Eli though, such work should not block removal of non-cairo code in files that are Part Of The Build, so bug 393001 should not be blocked by this bug.
I have removed bug 393001 from the blocked list (under protest). See http://lxr.mozilla.org/seamonkey/source/gfx/src/Makefile.in As long as non-Cairo path is in there, the source code in gfx/src/windows, gfx/src/beos, and gfx/src/mac (and gfx/src/photon) do refer to non-cairo 'deadcode' in the gfx/image libraries. Bug 393001 could just go ahead and remove those 'deadcode' from gfx/image, but this will mean that gfx/src/windows, mac, beos, etc will be even more out of date, and keeping them in CVS only will confuse people.
No longer blocks: 393001
xfsunoles, you already removed windows and mac from gfx/src/Makefile.in. Are you planning to remove the code in those directories (bugs already filed)?
(In reply to comment #10) > xfsunoles, you already removed windows and mac from gfx/src/Makefile.in. Are > you planning to remove the code in those directories (bugs already filed)? > I don't have the CVS access to do it.
All dependent bugs are closed and all platform specific code has been removed from gfx, so this bug can also be closed!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.