326787 - day/week view fails if event end is on next day [exception in getStartEndMinutesForOccurrence]

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Day/week view fails if event end is on next day. (Sunbird and Lightning)

1. Create an event lasting 00:00 - 23:59 on the same day.
2. Change end date to the next day, e.g. 00:01.

Actual result: Error in JavaScript console:

  ---------------------------------------------------------------------
  Error: [Exception... "Component returned failure code: 0x80004005
  (NS_ERROR_FAILURE) [calIDateTime.hour]"  nsresult: "0x80004005 
  (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/
  calendar-multiday-view.xml :: getStartEndMinutesForOccurrence :: line 537" 
  data: no]
  ---------------------------------------------------------------------

Afterwards Sunbird/Lightning can't be used anymore. Error occurs again during next startup because event is still in database. You have to edit storage.sdb or create a new profile to get rid of this.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: clone startDate and endDate before altering

Comment 2

[Stefan Sitter [:ssitter]]

*** Bug 326796 has been marked as a duplicate of this bug. ***

Comment 3

[Joey Minta]

Comment on attachment 211477 [details] [diff] [review]
clone startDate and endDate before altering

Clone is expensive since it involves creating a new xpcom object.  (getInTimezone is already going to do this, too.)  I think we should probably just work with js-variables sHour, sMinute, eHour, and eMinute.  Then we can reset those to 0 or 24 cheaply, as needed.  Thoughts?

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: use js variables

This patch uses js variables as proposed by Joey.

Comment 5

[Joey Minta]

Comment on attachment 211490 [details] [diff] [review]
use js variables

Sweet! r=jminta

Comment 6

[Joey Minta]

patch checked in.

Comment 7

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060927 Calendar/0.3a2+