32685 - using keyboard, can still pop out submenus for disabled menu items

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[:deanis74]

Use the keyboard to navigate to the View > Use Stylesheet menu item, which is 
disabled and has a submenu associated with it.  Press the right arrow.

Actual Results: The associated submenu opens.

Expected Behavior: Based on Windows menu behavior, the next item on the menu 
bar, Search in this example, should be opened.

OS: NT4 sp6a
Build: 2000032108

Comment 1

[David Hyatt]

Aww, I was hoping no one would discover this. ;)

Comment 2

[:deanis74]

You know me and menus!

Comment 3

[Kevin Puetz]

confirmed on Debian Linux/PowerPC, changing to XP.

Comment 4

[:deanis74]

I've got a fix for this at home.  It would be attached by now if my stupid %@#$ 
internet connection hadn't gone down last night.

Comment 5

[:deanis74]

Attachment: Here's the fix. It adds a MenuIsDisabled() method to nsIMenuFrame and nsMenuFrame.

Comment 6

[Peter Trudelle]

Mass moving M17 bugs to M18

Comment 7

[:deanis74]

Adding 'patch' keyword.  Should have done this a while back.

Comment 8

[Peter Trudelle]

mass-moving all bugs to m21 that are not dofood+, or nsbeta2+

Comment 9

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 10

[Peter Trudelle]

nsbeta3-, but not futuring since we could still take the patch. ->pinkerton

Comment 11

[Blake Ross]

*** Bug 43740 has been marked as a duplicate of this bug. ***

Comment 12

[Blake Ross]

r=blake

Comment 13

[Chris Waterson]

a=waterson

Comment 14

[Mike Pinkerton (not reading bugmail)]

checked in

Comment 15

[:deanis74]

Hey, I didn't make it as a contributor in two of the three files - what a rip!  
(Just jokin')

Comment 16

[Daniel Veditz [:dveditz]]

Adding keyword to bugs with nsbeta3 triage value in status whiteboard so 
tracking queries will not be misled

Comment 17

[:deanis74]

verified fixed on WinNT using build 2000081404.  I couldn't find a disabled menu
with a submenu anymore in Mozilla, so I had to go into navigatorOverlay.xul and
change:
     <menu value="&useStyleSheetMenu.label;" disabled="false">
to:
      <menu value="&useStyleSheetMenu.label;" disabled="true">