Closed Bug 327089 Opened 19 years ago Closed 18 years ago

Add new products to Hendrix

Categories

(Webtools Graveyard :: Hendrix, defect)

Product:
Webtools Graveyard
Component:
Hendrix
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: reed, Assigned: gerv)

References

(
URL
)

Details

Attachments

(1 file, 3 obsolete files)

Patch v.4
1.93 KB, patch
Details | Diff | Splinter Review 
Seamonkey and Sunbird need to be added to the product list on hendrix.m.o. There may be other projects/products I am not thinking of at this moment that are missing.
While you are editing index.html.tmpl, please change http->https for the Bugzilla link.
Taking
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) — — Splinter Review 
Added two products and change http links to https.
Attachment #211834 - Flags: review?(gerv)
Assignee: gerv → bugzilla.mozilla
Status: ASSIGNED → NEW
why https://www.mozilla.org/support/ ?

+	       <option name="Seamonkey">Seamonkey</option>
+	       <option name="Sunbird">Sunbird</option>

you should use same form, means not use tab.
Right, I'll change that link.  the https does work though.

(In reply to comment #4)

> you should use same form, means not use tab.
> 

What do you mean by this?
Attached patch Patch v2 (obsolete) — — Splinter Review 
Removed the https link for the mozilla.org site
Attachment #211834 - Attachment is obsolete: true
Attachment #211836 - Flags: review?
Attachment #211834 - Flags: review?(gerv)
Attachment #211836 - Flags: review? → review?(gerv)
(In reply to comment #5)
> (In reply to comment #4)
> > you should use same form, means not use tab.
> What do you mean by this?

\t used to indent

(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > you should use same form, means not use tab.
> > What do you mean by this?
> \t used to indent

Yes, please use the same indenting like the other products (spaces instead of tab).
Attached patch Patch v3 (obsolete) — — Splinter Review 
OK, no tabs used, spaces only in vim.  3rd time lucky ;)
Attachment #211836 - Attachment is obsolete: true
Attachment #211889 - Flags: review?(gerv)
Attachment #211836 - Flags: review?(gerv)
Deer Park is being renamed as per bug 308973, so pending a final name for Firefox Trunk, that will need to be updated, too.
Marking as a dependency and will update the patch as soon as that bug is closed.
Depends on: 308973
Comment on attachment 211889 [details] [diff] [review]
Patch v3

Clearing review request until dependant bugs are closed.
Attachment #211889 - Flags: review?(gerv)
Attachment #211889 - Flags: review+
Gerv, thanks for the review.  Would it be possible to check this is in for me?  I don't have permissions.
Actually, we should probably wait for bug 308973.

Gerv
Status: NEW → ASSIGNED
Attached patch Patch v.4 — — Splinter Review 
Here's a patch with the new names from bug 308973.

Gerv
Assignee: bugzilla.mozilla → gerv
Attachment #211889 - Attachment is obsolete: true
Thanks for the patch, Ray :-)

Checking in ./template/index.html.tmpl;
/cvsroot/mozilla/webtools/hendrix/template/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.13; previous revision: 1.12
done

Gerv
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
+          <option name="Seamonkey">Seamonkey</option>

can you please capitalize this as "SeaMonkey"? Thanks :-)
Done. :-)

Checking in template/index.html.tmpl;
/cvsroot/mozilla/webtools/hendrix/template/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.14; previous revision: 1.13
done

Gerv
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: