327101 - Ctrl+Left should close autocomplete

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[Jesse Ruderman]

Steps to reproduce on Windows:
1. Start typing into the address bar.
2. Select an autocomplete entry with the Down arrow key.
3. Press Ctrl+(Shift)+Left.
4. Press Delete.  (In Firefox 1.5.0.1, press Shift+Delete instead.)

Result: autocomplete entry is deleted unexpectedly.

Expected: normal text-editing behavior for Delete (delete selection or next character) or Shift+Delete (cut selection).

The Left arrow key and Home already close autocomplete, so fixing this bug would also improve consistency.  Opt+Left should probably be changed in the same way on Mac (just for consistency), even though this won't be a dataloss issue on Mac once bug 325737 is fixed.

This bug was originally mentioned in bug 325737 comment 1 by Gennady Feldman.

This can probably be fixed the same way bug 255116 was fixed.

Comment 1

[Jesse Ruderman]

Nominating for blocking Firefox 2.  Delete is a more common shortcut than Shift+Delete, so this is likely to be more of a problem now that Delete deletes autocomplete entries instead of Shift+Delete.

Comment 2

[Mike Connor [:mconnor]]

Needs a more generalized solution to ensure that any time of action that changes selection or cursor position kills the popup

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: wip (diff -w)

This seems to fix the case described here, but I've not gone through the different possibilities to make sure this doesn't regress anything. There might be a better fix for this, too. It'd sure be nice if nsIAutoCompleteController used the same key constants as nsIDOMKeyEvent...

Comment 4

[Ria Klaassen (not reading all bugmail)]

See also Bug 337695, possible dupe.

Comment 5

[Simon Bünzli]

*** Bug 340377 has been marked as a duplicate of this bug. ***

Comment 6

[Ria Klaassen (not reading all bugmail)]

*** Bug 337695 has been marked as a duplicate of this bug. ***

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 226066 [details] [diff] [review]
patch

so, it'd be nice to kill the event and return true after each switch block if cancel is true, since then we skip doing a bunch of additional checks, but its not that critical

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/autocomplete.xml 	1.44.2.15
mozilla/toolkit/content/widgets/autocomplete.xml 	1.65