Closed
Bug 327208
Opened 18 years ago
Closed 18 years ago
update default homepages for all 1.0.x builds (to match 1.5.0.x builds)
Categories
(Firefox :: General, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
mconnor
:
review+
dveditz
:
approval-aviary1.0.8+
|
Details | Diff | Splinter Review |
http://start.mozilla.org/firefox?client=firefox-a&rls=__MOZ_DISTRIBUTION_ID_UNQUOTED__:__AB_CD__:official (the URL used for 1.0.x default home pages) needs to be changed to be the same as: http://__AB_CD__.start.mozilla.com/firefox?client=firefox-a&rls=__MOZ_DISTRIBUTION_ID_UNQUOTED__:__AB_CD__:official (the URL used for 1.5.0.x releases). This change is needed for ja-JP, ja-JPM, zh-TW, zh-CN and ko-KR.
Assignee | ||
Updated•18 years ago
|
Summary: default homepages for CJKT need to be redirected to the yahoo home page → default homepage URLs for CJKT need to redirect to the yahoo home page
Comment 1•18 years ago
|
||
OK, I'm assuming you're asking for the 1.0 start pages of the CJKT browsers to get redirected to the current start pages we're using for 1.5... This'll need signoff from the marketing guys first. Also, while technically possible, start.mozilla.org is actually run by Google, and I think it would be quite odd, to say the least, to ask them to redirect a page to Yahoo (a competitor).
Assignee: server-ops → cbeard
Component: Server Operations → General
Product: mozilla.org → Marketing
QA Contact: justin → chofmann
Version: other → unspecified
This has signoff, don't worry about that. I had thought that we used our own server to redirect per-locale to Google or Yahoo in 1.5.0.x, but I now see that I'm mistaken there. That would be a general solution to this problem, in addition to giving us some useful data for tracking adoption trends.
Comment 3•18 years ago
|
||
We'll need to change the client code here - as Dave mentions we cannot implement a server fix.
Updated•18 years ago
|
Assignee: cbeard → gavin.sharp
Assignee | ||
Updated•18 years ago
|
Product: Marketing → Firefox
QA Contact: chofmann → general
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox1.5
Version: unspecified → 1.0 Branch
Assignee | ||
Comment 4•18 years ago
|
||
This changes the default start page URLs for 1.0.x builds to be the same as the default home pages for 1.5.0.x builds, for all locales. Since the locale codes changed from 1.0.x to 1.5.0.x (ja-JP -> ja, for example), the URLs for all locales should be checked to ensure that they are functional. It would be great if a list of all existing *.start.mozilla.com domains could be made, so that it can be compared against the locales shipped for builds from both 1.0.x and 1.5.0.x branches.
Attachment #214944 -
Flags: review?(mconnor)
Comment 5•18 years ago
|
||
Comment on attachment 214944 [details] [diff] [review] patch ok, this works, but we'll need to get some additional cnames created in order to make sure this works, more in one second.
Attachment #214944 -
Flags: review?(mconnor) → review+
Comment 6•18 years ago
|
||
http://lxr.mozilla.org/l10n-aviarybranch/source/browser/locales/ http://lxr.mozilla.org/l10n-mozilla1.8/source/ We have different locale sets (i.e. ca-AD for 1.0.x vs ca for 1.5.0.x). When I gave the list of cnames to be created, we used the 1.5 list, and ignored this. We just need a list of locale codes that are in 1.0.x that aren't in 1.5, based on the linked lists.
Comment 7•18 years ago
|
||
This is considered critical for 1.0.8 by John Lilly and Mike Schroepfer
Flags: blocking-aviary1.0.8+
Comment 8•18 years ago
|
||
Is this ready to land for aviary 1.0.8? If so, please set the flag on the patch to "?". I will check on any adiditonal locales in 1.0.x not in 1.5 later this evening. Does this fix 330113 or does that require a seperate fix?
Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #8) > Is this ready to land for aviary 1.0.8 No, this depends on bug 330482. That bug is waiting for sign-off to create the domains that this patch will add. > Does this fix 330113 or does that require a seperate fix? Bug 330113 is a duplicate of this bug - I'll mark it as such.
Assignee | ||
Comment 10•18 years ago
|
||
*** Bug 330113 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 11•18 years ago
|
||
Re-summarizing bug to match what the patch does.
Summary: default homepage URLs for CJKT need to redirect to the yahoo home page → update default homepages for all 1.0.x builds (to match 1.5.0.x builds)
Comment 12•18 years ago
|
||
Comment on attachment 214944 [details] [diff] [review] patch approved for ff1.0.8 a=dveditz Please land ASAP
Attachment #214944 -
Flags: approval-aviary1.0.8+
Assignee | ||
Comment 13•18 years ago
|
||
Checked this in on the 1.0.1 branch. other-licenses/branding/firefox/content/browserconfig.properties 1.1.2.4.2.1
Assignee | ||
Comment 14•18 years ago
|
||
This should be fixed, now that bug 330482 is fixed. Still needs verification.
Comment 15•18 years ago
|
||
Just to make sure, it is the intended behaviour that we change the start page (err, home page) for existing profiles for users that didn't change from the default?
Yes, that is exactly the intent.
Comment 17•18 years ago
|
||
Reopening, doesn't look like the browserconfig.properties changes made it into the latest 1.0.8 candidates. Testing Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.13) Gecko/20060319 Firefox/1.0.8, that file still looks like this: browser.startup.homepage=http://start.mozilla.org/firefox?client=firefox-a&rls=org.mozilla:ja-JP:official browser.startup.homepage_reset=http://start.mozilla.org/firefox?client=firefox-a&rls=org.mozilla:ja-JP:official And therefore with a clean profile, I am still taken to the Google startpage. :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 18•18 years ago
|
||
This is the cost of learning the lesson that Bonsai display PST, while CVS reports GMT. I'll respin the builds and stick them in the 1.0.8-candidates directory.
Comment 19•18 years ago
|
||
There was a build issue with the dates used for pulling the tree. It was fixed and the latest 1.0.8 candidates look good on Linux.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Comment 20•18 years ago
|
||
v.fixed on 1.0.x Aviary branch with latest Linux builds for ja-JP, ko-KR, zh-CN, and zh-TW.
Status: RESOLVED → VERIFIED
Keywords: fixed-aviary1.0.8 → verified-aviary1.0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•