327373 - form buttons are displayed incorrectly when dotted focus ring width is set to 0

Status: RESOLVED WORKSFORME

(Camino Graveyard :: HTML Form Controls, defect)

Description

[Chris Whitehorn]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0

If you disable the dotted focus ring, the button widgets seem to "grow" and be a size it shouldn't be.

Reproducible: Always

Steps to Reproduce:
1. Go to about:config
2. Type "focus" in the filter box
3. Change the value for browser.display.focus_ring_width to "0"

(This can also be reproduced with the CamiTools add-on or a custom user.js file)

Actual Results:  
The button widgets are incorrectly displayed. They are not the correct size.

Expected Results:  
The widgets would stay the same and be displayed properly.

Comment 1

[Chris Lawson (gone)]

Smokey, might this be some more CSS-fu on forms widgets? I see what the reporter's talking about and it's pretty fugly.

cl

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'd guess we're making some sort of assumption about the value of that pref in our style rules somewhere; I haven't had a chance to play with things.  

But it may also be related to some of our other button bugs in that somewhere within Gecko there's an assumption that a button is a rectangle, and we have to so some carefully-crafted CSS to keep it pill-shaped (e.g., make sure the selection color fills the whole thing, not just the rectangle, bug 310266, and a related one I haven't filed about occasional cropping).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Does this happen in 0.8.4?  I wonder if this is another regression from bug 298111?  If things look OK in 0.8.4, this one should depend on bug 298111.

Comment 4

[ender.mb]

I tested this in 0.8.4 versus 2006070104 trunk, and the results were a little odd. This issue is still present in 0.8.4, but to a lesser degree. For example, the "Commit" button on this page is enlarged noticeably with the focus ring off in 0.8.4, but not as large as it is in current builds. 

Probably not related, but the old build doesn't have the odd aqua focus rings on push buttons either, I had thought that was a Tiger thing.

Comment 5

[Chris Whitehorn]

Its looking better in the trunk (using 12/29 now). Most if not all widgets are normal size. There are a still some glitches with positioning the widgets and disappearing on the page, but I think we'll have to wait until Cairo matures before debugging further.

Comment 6

[Stuart Morgan]

Fixed by the trunk widget rewrite.