327612 - Firefox does not stay in safe mode after software update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[dolphinling]

If Firefox is started in safe mode and then an update is installed and "restart now" is chosen, Firefox reopens not in safe mode. It should stay in safe mode.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Confirming this happens with a win32 1.5 -> 1.5.0.1, using commmand line arguments -P -safe-mode.

bsmedberg, is this an edge case or the tip of an iceberg for not passing arguments when restarting ?

Comment 2

[Benjamin Smedberg]

I'm inclined to think that we should disable "automatic" update in safe mode, but continue to allow manual check-for-update. In that case when we restart we shouldn't be in safe mode.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I guess this depends on bug 310378?

Comment 5

[Robert Strong (they/them - no direct email)]

Same is true when in safe mode and restarting after installing an add-on.

Comment 6

[Benjamin Smedberg]

IMO the desired UI action if you install or uninstall an add-on in safe mode is to return to regular mode after restart.

Comment 7

[Robert Strong (they/them - no direct email)]

I agree... the issue then becomes that nsIAppStartup would need to separate the cases when the app should stay in safe mode and when it should not since both app update and the extension manager are consumers of this method.

Comment 8

[Benjamin Smedberg]

I'm not convinced that there is any time when we'd want to restart in safe mode. See comment #2

Comment 9

[Ryan Li]

Yes I agree with comment #2.

Comment 10

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> I'm inclined to think that we should disable "automatic" update in safe mode,
> but continue to allow manual check-for-update. In that case when we restart we
> shouldn't be in safe mode.
I'm more concerned about there being a very small subset of users that use safe mode thinking that it is safer and not getting updates due to automatic updates being disabled in safe mode than I am concerned about the small subset of users that want to stay in safe mode after an auto update.

Comment 11

[Robert Strong (they/them - no direct email)]

This is as fixed as it is going to be fixed by bug 596813 which utilizes the functionality introduced by bug 542122. Now if you are in safe mode and choose to apply an update which restarts Firefox then the safe mode dialog is displayed.