327675 - Require Windows 2000 or better

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Stuart Parmenter]

We currently set WINVER to 0x400 indicating 95/NT4 support.

Since we're only going to support Win2k+ in cairo builds (and since we're in the year 2006...) we should set WINVER to reflect that so that we can use features that are only defined if that is set.

Comment 1

[Stuart Parmenter]

Attachment: configure changes

Comment 2

[Benjamin Smedberg]

What features does this actually affect?

Comment 3

[Stuart Parmenter]

I ran across the requirement on a patch I'm currently working on for cairo that checks if the destination DC supports AlphaBlend.  SHADEBLENDCAPS and SB_NONE (and the other possible results) are all only defined if WINVER >= 0x500
See wingdi.h for other such things.

GetDeviceCaps(dst->dc, SHADEBLENDCAPS) == SB_NONE

Comment 4

[Hermann Schwab]

June 2004 Win98 still held 16% market share
http://www.google.com/press/zeitgeist/zeitgeist-jun04.html

Which Firefox/Mozilla/Seamonkey version will be the last usable on Win98?
Currently there are problems on Win98 regarding text in svg, is that the reason to exclude win98?

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #4)
> June 2004 Win98 still held 16% market share
> http://www.google.com/press/zeitgeist/zeitgeist-jun04.html
> 
> Which Firefox/Mozilla/Seamonkey version will be the last usable on Win98?
> Currently there are problems on Win98 regarding text in svg, is that the reason
> to exclude win98?

June 2004 was almost 2 years ago.  Recent numbers are much, much lower.  Firefox 1.5/Mozilla 1.8.1 will be the last usable version on Win98.  There are a number of Win32 technologies that we want to be able to take advantage of that are unavailable/incomplete on anything earlier than Win2k (e.g. uniscribe).

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Er, Firefox 2/Mozilla 1.8.1, I meant.

Comment 7

[Benjamin Smedberg]

Comment on attachment 212269 [details] [diff] [review]
configure changes

I don't want to make these defines variable on the toolkit (which is a gecko configuration option and isn't directly relevant to other code). I'd prefer a --with-win32-target=400/500 variable, defaulting to 500 for all cases and allowing builders to downrev to 400 if they need to.

Comment 8

[Stuart Parmenter]

the 'windows' toolkit is going away in the not-so-distant-future, so we'll require 0x500.  Making it a configure option doesn't make any sense to me.

Comment 9

[Benjamin Smedberg]

Then why not set it unconditionally? I figured you kept it at 0x400 for some reason.

Comment 10

[Stuart Parmenter]

Because we're trying to make sure that the old stuff works until we really and truely flip the switch.

Comment 11

[Benjamin Smedberg]

Then add the configure flag: our build system already has enough bizarre side-effects without adding another.

Comment 12

[Stuart Parmenter]

Attachment: just change it across the board.

i think this is the wrong fix as it now makes the trunk able to rely on win2k+ only features, but adding a configure flag here is stupid and bsmedberg says this is OK.

Comment 13

[[e-mail]]

(In reply to comment #12)
>i think this is the wrong fix as it now makes the trunk able to rely on win2k+
>only features, but adding a configure flag here is stupid and bsmedberg says
>this is OK.
Actually it requires win2k+ for e.g. the filepicker.

Comment 14

[Stuart Parmenter]

We need to rethink this as the thunderbird windows tinderbox hasn't cycled since we landed this patch.  I agree that the patch that went in is the long term fix, and hopefully in a few weeks (month?) when the tinderboxes are upgraded, we can check it back in, but until then  I think we should back it out and check in my orignal patch.

Comment 15

[Benjamin Smedberg]

Attachment: Grr

We can hack the bad tbird tbox with --with-windows-version=400 for the time being.

Comment 16

[Benjamin Smedberg]

Attachment 213047 [details] [diff] fixed on trunk.

Comment 17

[Serge Gautherie (:sgautherie)]

You might want to have a look at (fixed) bug 305187 for possible followups/cleanups...

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #13)
> Actually it requires win2k+ for e.g. the filepicker.

(now fixed in bug 328306)

Comment 19

[Masatoshi Kimura [:emk]]

Comment on attachment 213047 [details] [diff] [review]
Grr

The tbird tbox problem was solved (see bug 331433). We could now back out this.