331433 - tinderboxes patrocles and cerberus have INCLUDE path wrong

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Jungshik Shin]

Apparently, thunderbird tinderbox patrocles doesn't prepend PSDK INCLUDE directory with VC6 INCLUDE PATH as clearly documented in the build document. VC6 header files have some problems with APIs like GetFileVersionInfo and should be overriden by header files in a recent PSDK. This is the cause of tinderbox break after the patch of bug 162361 got landed. 

See also bug 162361 comment #120, bug 162361 comment #110.

Comment 1

[Jungshik Shin]

http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites_on_the_1.7_and_1.8_Branches

rem --- Set MSVC environment vars
call %VCVARS%

rem --- Prepend SDK paths
rem --- Only required for MSVC6
set PATH=%MSSDK%\bin;%PATH%
set INCLUDE=%MSSDK%\include;%INCLUDE%
set LIB=%MSDDK%\lib;%LIB%

Comment 2

[Jungshik Shin]

Per bug 162361 comment #159, I'm giving this to preed.

Comment 3

[Scott MacGregor]

jshin, in the future, if the over worked build team doesn't have time to re-configure the tinderbox machine, please back out your original checkin. It's not really acceptable to have a nightly build machine burning for 4 days! I feel partially to blame because I didn't notice we didn't have trunk nightlies until today :).

Comment 4

[Scott MacGregor]

Paul, patrocles needs the following SDK installed on it:

http://www.microsoft.com/msdownload/platformsdk/sdkupdate/psdk-full.htm

I would like to do so with your permission.

Thanks.

P.S. Do you know if this is a new build reuqirement? It looks like someone added it to the build reqs page on March 11th. I wonder if there are other build machines out there we need to update as well.

Comment 5

[Jungshik Shin]

(In reply to comment #4)

Scott, I'm sorry I haven't contacted you about the issue. (I thought you'd had noticed it immediately...., but that can't be an execuse for not contacting you.) I'm also sorry for breaking the tinderbox.

> P.S. Do you know if this is a new build reuqirement? It looks like someone
> added it to the build reqs page on March 11th. I wonder if there are other
> build machines out there we need to update as well.

No, it's not a new requirement. It's been there for a very long time. The change made on March 11 was probably replacing the link to the latest PSDK with the link to Feb 2003 edition of PSDK (VC6 still used for 1.8 branch build does NOT work with the latest PSDK, which was pointed out by me and others in Talk page. That appears to have been corrected on March 11.)
 
IIRC, it's there  when I first configured my Windows box for mozilla build (2002?. not at the current location but at its old url), but my memory is not so reliable. 

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Workaround for VC6 wthout PSDK

Please consider checking this in if build team is too busy to update patrocles soon.
I've confirmed this works on VC6 without PSDK, VC6 with PSDK, and VC8.

Comment 7

[Scott MacGregor]

I've taken the liberty of checkin in this work around so we can try to get trunk builds going again until we can fix the build machine.

Comment 8

[Jungshik Shin]

cerberus has the same problem. I'm hoping to land my patch for bug 162361 on 1.8 branch (after baking long enough on the trunk). I can work around the problem using the patch here, but it'd be nice if both patrocles and cerberus are fixed soon.

Comment 9

[Masatoshi Kimura [:emk]]

Comment on attachment 216186 [details] [diff] [review]
Workaround for VC6 wthout PSDK

Already checked in and incorporated into attachment 217241 [details] [diff] [review].

Comment 10

[J. Paul Reed [:preed]]

Can I resolve this, now that trunk has its own build machine? Is this necessary for 1.8-branch builds?

Comment 11

[Scott MacGregor]

I'm pretty sure we can close this out now that the trunk build machine has been upgraded to VS8. jshin, let me know if I've got that wrong!

Comment 12

[Jungshik Shin]

If we're interested in removing the unnecessary clutter (work-around for VC6 without PSDK) in our source code for 1.8 branch, we'd want to resolve this problem (assuming patrocles and cerberus are still used for 1.8 branch). If that's not a concern at all, we can just close this bug.