327760 - Add colors to the views - beautify Sunbird/Lightning theme

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

Old views had nice blue colors. Current, new, views are gray and boring. Colors should be added to make it look nicer.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: first version

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: screenshot of monthview

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: screenshot of weekview

Comment 4

[Stefan Sitter [:ssitter]]

I have made a userChrome.css version out of the 'old' Sunbird look and this patch here. The preliminary result can be found at http://wiki.mozilla.org/User:Ssitter/UserChrome . 

This way it should be easier to play around with several color combinations etc. without the need to patch Sunbird/Lightning and get some feedback. The 'old' look is not necessarily the best one - but it is less boring than the current one.

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: minimum approach

Minimum approach to get some colors into the views. Theme is far from being finalized but for 0.3a2 it should be sufficient. I'll add screenshot soon.

Comment 6

[Stefan Sitter [:ssitter]]

Attachment: minimum approach - week view

If someone has a better idea for the 'today' column?

Comment 7

[Stefan Sitter [:ssitter]]

Attachment: minimum approach - month view

Comment 8

[Joey Minta]

Comment on attachment 217043 [details] [diff] [review]
minimum approach

+calendar-event-column[selected="true"],
 calendar-header-container[selected="true"] { 
-  background: #ffe79c !important;
-}
-
-calendar-header-container { 
-  border-left: 1px solid #999999;
-  border-top: 1px solid #999999;
+  background: #D5E3F2;
 }

calendar-month-day-box-item[selected="true"] { 
   color: #000000 !important;
   background: #ffdb67 !important;
 }
The one thing that I like about the current color scheme is that 'selected' has similar colors regardless of whether it's a column, box, or item.  I think that helps to reinforce the notion of selected, and can help train the user to associate that quickly with references to 'selected day' and 'selected event'.  Can we preserve that?  It would probably also help to distinguish the 'today' problem you mentioned.

Talk to me on IRC about coordinating this landing with Bug 321545 when you get a chance too.

Comment 9

[Stefan Sitter [:ssitter]]

Attachment: minimum approach, v2

theme looks similar to the first attempt but leave currently used yellow tone for selected days.

Comment 10

[Joey Minta]

Comment on attachment 217445 [details] [diff] [review]
minimum approach, v2

Alright, this looks good enough for 0.3a2. r=jminta.  I already landed the css restructuring so I'm working on merging this in by hand.  I'll attach a checkin-diff once I get that sorted out.

Comment 11

[Joey Minta]

Attachment: minimum approach, v2 as checked in

This is how the patch looked, ported to the restructured css files.

Comment 12

[Joey Minta]

Bug no longer blocks 0.3a2.

Comment 13

[Stefan Sitter [:ssitter]]

This was fixed for Sunbird 0.3 Alpha 2 release. 
Please file new bugs for further improvements to the default theme.