327764 - SVG patterns are still not live

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Same testcase as bug 308589, but easier to work around (resizing the window is sufficient) and possibly Mac-only.

Steps to reproduce:
1. Load the testcase.
2. Click "remove the red rectangle from the pattern" or "turn the green rectangle yellow".

Result: An alert appears, but there is no visible change to the part of the page that uses the pattern until the window is resized.

Comment 1

[Jesse Ruderman]

Attachment: testcase from bug 308589

Comment 2

[Timothy Lee]

Under Windows, seeing this bug in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060219 Firefox/1.6a1.

Comment 3

[tor]

Attachment: testcase without alerts (which cause full repaints on linux)

Comment 4

[tor]

Attachment: live patterns via nsIMutationObserver

Works, but causes a lot of compiler warnings about hidden methods due to name collisions between nsIFrame and nsIMutationObserver.

Comment 5

[tor]

Maybe we want to have the pattern element observe itself from content land and tell the pattern frame that it has modified, instead?

Comment 6

[tor]

Attachment: alternate approach

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 228887 [details] [diff] [review]
alternate approach

Yeah, you don't want to make the frame an nsIMutationObserver since it is (for now) refcounted.

>Index: content/svg/content/src/nsSVGPatternElement.cpp

>+nsSVGPatternElement::NodeWillBeDestroyed(const nsINode *aNode)
>+{
>+  RemoveMutationObserver(this);
>+}

No need to do this, all observers will be removed when the node dies anyway.

r/sr=sicking with that fixed

Comment 8

[tor]

Attachment: version for checkin

Comment 9

[tor]

Checked in.

Comment 10

[Jesse Ruderman]

I'm still having problems with the second testcase (Mac trunk debug).  Clicking the thing to turn the green square yellow often shifts the pattern but doesn't make anything yellow.

Comment 11

[Jesse Ruderman]

I filed bug 372574 for the problem in comment 10.