32802 - [UI] create a pref item for Send message default charset

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Katsuhiko Momoi]

In Bug 23540, this UI request was taken care of by a workaround
fix in the charset menu itself.
We should move this item into a Preference dialog along with 
some other mail-related items. We need to find a proper
place for this. Something like: 

 Edit | Prefs | Mail & Newsgroups | International | Send options

Here's bob jung's description of the request in Bug 23450, we can
use this as a begeinning point of discussion.

------------------------------------------
The infrastructure we need for Beta from the mail team:
  1 - create new mail pref panel for internationalization
  2 - In this panel, create a drop down for the default mail sending
      charset that sets the "intl.character_set_name" preference.  The
      display names for the dropdown entries should be stored in a .dtd
      file (not .xul) for localizability.  The pref values can be hard-
      coded in the .xul for Beta1.  You can leverage the work done for
      the mail charset menu:

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/messe
ngercompose.xul 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/locale/en-US/
messengercompose.dtd

Post Beta1, I18N will rewrite the pref panel XUL to build up the dropdown
entries from a scriptable interface which will query the charset modules.
------------------------------------------

To clarify my previous comment, when I said you can leverage from the mail
charset menu .xul and .dtd, I meant you can get the list of display names
and pref charset values to be used for the dropdown.  The display names
in the .xul are reference via entities that come from the .dtd.
------------------------------------------

One of the things we need to do is to define the items to 
be placed under the International section of the preferences.

Comment 1

[Katsuhiko Momoi]

assigning myself as QA contact.

Comment 2

[Katsuhiko Momoi]

Correction: The send default charset pref is now:

mailnews.send_default_charset

the old one mentioned above: intl.character_set_name

has been obsoleted.

Comment 3

[bobj]

(Beta1 currently has a workaround in the Mail Composer's View|Character Coding
menu which needs to be replaced.)

If there are only 2 additional I18N mail specific UI prefs:

 bug 32720 [UI] Create a pref item for Default Display charset for Messenger 
 bug 32802 [UI] create a pref item for Send message default charset 

then I don't think this warrants a new International pref panel.  Instead we
should just add these to the Edit | Prefs | Mail & News | Messages
panel: (1) under "For incoming messages" section and (2) under "For outgoing
messages" section.  Each would look something like:

   Default Character Coding       [dropdown list]

Comment 4

[bobj]

German and mail folks,
  Are you OK with adding this to the Edit | Prefs | Mail & News | Messages
prefs panel?

Comment 5

[bobj]

Assuming this plan is OK, reassigning to 

Comment 6

[nhottanscp]

Accepting, to be added inside "For outgoing messages" in Messages pref, I am not 
sure any room is left for new items (if not, the item maynot be seen unless 
resizing the pref dialog).

Comment 7

[nhottanscp]

Attachment: screen shot of new pref items

Comment 8

[nhottanscp]

Attached a screen shot of this pref. I am going to check this in if I don't hear 
any objections.
Because of the additional items, I needed to change the default pref window 
size to 550. Any problem of that? With 640 * 480 screen, I cannot see the 
bottom edge of the dialog but I can see both "OK" and "Cancel" buttons at the 
bottom.

Comment 9

[nhottanscp]

Checked in the UI. The charset list is fixed, same as the send charset menu.
This will change to use RDF after the send menu to be dynamic.

Comment 10

[nhottanscp]

fix checked in yesterday (RDF version).

Comment 11

[jglick]

Mail Prefs panels will be reorganized.  These ok for international?  Please see 
attachments.

Comment 12

[jglick]

Attachment: Message Composition Pref Pane

Comment 13

[jglick]

Attachment: Message Display Pref Panel

Comment 14

[Katsuhiko Momoi]

In Mozilla, we changed the charse menu name from "Character Set"to "Character Coding".
Please substitute "Character Coding" instead in the above 2 dialogs.

Comment 15

[Katsuhiko Momoi]

Mistakenly re-oprned the bug. 

Comment 16

[jglick]

Done. http://gooey/client/5.0/specs/mail/Prefs/Preferences.html

Comment 17

[Katsuhiko Momoi]

Thank you, Jennifer!

Comment 18

[Katsuhiko Momoi]

** Checked with 5/26/2000 Win32 & Linux  builds **

The pref item is now under: Mail & Newsgroups | Composing Messages | Languages.
It sets the default mail send charset and is working as intended.

Next to check is Mac.

Comment 19

[Katsuhiko Momoi]

** Checked with 5/27/2000 Mac build **

The send default charset pref is working as intended. It sets
the send default properly and the choice is reflected on
a new mail composition.

Marking the fix verified.