328354 - "Set As Desktop Background..." is upside down and has inverted colors.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[hhh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060223 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060223 Firefox/1.6a1

see summary

Reproducible: Always

Steps to Reproduce:
1.Open an image file in the browser.
2.right-click, choose "Set As Desktop Background..."
3.

Actual Results:  
Colors are inverted, image is upside down.

Comment 1

[Jo Hermans]

is this a regression from bug 327580 (wild guess) ?

Comment 2

[hhh]

This WFM in the latest respin, fixed?...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060224 Firefox/1.6a1 ID:2006022408

Comment 3

[hhh]

Sorry, same build ID for cairo and non-cairo and I got confused, I still see this.

Comment 4

[Kevin Brosnan]

This WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060331 Firefox/1.6a1 ID:2006033104

Comment 5

[Jonathan Haas]

Currently "Set As Desktop Background..." doesn't do anything because of Bug 332484 
These bug are probably related.

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to comment #5)
> Currently "Set As Desktop Background..." doesn't do anything because of Bug
> 332484 
> These bug are probably related.
> 

I doubt they are related because previously the desktop preview used to show the image upside down and with the wrong colors.  It no longer does, just now the background never actually gets set.

I think this bug might be fixed.  But that can not be verified since the entire "set as desktop background" functionality now appears to be hosed.

Comment 7

[Stuart Parmenter]

Attachment: fix

this fixes it

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 227162 [details] [diff] [review]
fix


This looks fine, except I'd try to simplify this loop some..

>+#else
>+        // write out the image data backwards because the desktop won't
>+        // show bitmaps with negative heights for top-to-bottom
>+        PRUint32 i = length;
>+        do {
>+          i -= bpr;
>+
>+          stream->Write(((const char*)bits) + i, bpr, &written);
>+          if (written == bpr) {
>+            rv = NS_OK;
>+          } else {
>+            rv = NS_ERROR_FAILURE;
>+            break;
>+          }
>+        } while (i != 0);
>+#endif

maybe something like

if (bpr * num_rows > length)
   return error;

int left;
for (i = num_rows; i > 0; i--) {
  void *row = bits + (i-1)*bpr;
  left = bpr;
  while (left != 0) {
    stream->Write(row, bpr, &written);
    left -= written;
  }
}

and handle Write() returning an error..

Comment 9

[Stuart Parmenter]

eh, I like my loop better.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 227162 [details] [diff] [review]
fix

r=sspitzer, looks reasonable to me.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 227162 [details] [diff] [review]
fix

r=sspitzer

Comment 12

[jag (Peter Annema)]

You could've moved the rv = NS_OK outside the loop.