332484 - set as desktop background fails

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kevin Brosnan]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060331 Firefox/1.6a1 ID:2006033104

Steps to reproduce.
Chose an image file
right click and select Set as desktop background...
choose any option from the drop down
press set as desktop background
nothing happens

The JavaScript console shows the following error with javascript.options.showInConsole true set.
Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIShellService.setDesktopBackground]
Source file: chrome://browser/content/setDesktopBackground.js Line: 96

This appears to be a Windows only issue, Philor tested on a Mac and could not reproduce.

Comment 1

[Andreas Grillenberger]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060401 Firefox/2.0a1

I can confirm this bug under Bon Echo Alpha 1 with small images, like a login or go button. With bigger images I can't confirm.

Comment 2

[Kevin Brosnan]

Regression range 2006.03.24 works 2006.03.25 broken, tested on Trunk Firefox/1.6a1.

Comment 3

[Ludovic Hirlimann [:Usul]]

Adding keyword

Comment 4

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060401 Firefox/1.6a1
Can't reproduce with the latest build which is non-cairo so I think this might be a deterioration of Bug 328354. 

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

No bitmap file is being generated, possibly a problem in WriteBitmap? http://lxr.mozilla.org/mozilla/source/browser/components/shell/src/nsWindowsShellService.cpp#663

> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060401
> Firefox/2.0a1
> 
> I can confirm this bug under Bon Echo Alpha 1 with small images, like a login
> or go button. With bigger images I can't confirm.
> 

Latest branch is WFM on images of all sizes for me.

Comment 6

[Andreas Grillenberger]

At mine, latest branch is also WFM now.

Comment 7

[u88484]

WFM also, marking as so.

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Kurt, this bug was not filed against the branch. As of today's trunk build (20060406), this is still a problem. Reopening.

Comment 9

[u88484]

Oops I start my branch build instead of trunk, sorry about that.

Comment 10

[Ria Klaassen (not reading all bugmail)]

*** Bug 336783 has been marked as a duplicate of this bug. ***

Comment 11

[Jason Bassford]

No specific bug / patch referenced as the fix.

-> WORKSFORME

Comment 12

[Kevin Brosnan]

This was definitely fixed by the patch for bug 328354. Use the view bug activity to see that this bug was marked fixed by one of the lead developers for cairo.

Comment 13

[Jason Bassford]

A lead developer marking it fixed still doesn't give any QA on what fixed it.  But specifically identifying that it was bug 328354 (I presume a re-working of the code that caused the regression in the first place) is good.