Closed
Bug 328390
Opened 19 years ago
Closed 19 years ago
Selection color of images is backwards
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pavlov, Assigned: pavlov)
References
()
Details
Attachments
(1 file)
|
8.65 KB,
patch
|
vlad
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Selection color of images is backwards. It currently draws a partially transparent image over the selected area. we could probably just rewrite this to draw a partially transparent rect instead.
|
||
Comment 1•19 years ago
|
||
related to bug 328386/bug 328354?
|
Assignee | |
Comment 2•19 years ago
|
||
*** Bug 328386 has been marked as a duplicate of this bug. ***
|
||
Comment 3•19 years ago
|
||
(In reply to comment #0)
The "partially transparent rect" should respect the background-color of ::-moz-selection but override the alpha value.
|
|
Assignee | |
Comment 4•19 years ago
|
||
with cairo we no longer need to create an image to draw the selection partially transparent so i've ifdefed out all the related code for doing that.
Assignee: nobody → pavlov
Status: NEW → ASSIGNED
Attachment #215105 -
Flags: superreview?
Attachment #215105 -
Flags: review?(vladimir)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #215105 -
Flags: superreview? → superreview?(roc)
Attachment #215105 -
Flags: review?(vladimir) → review+
Comment on attachment 215105 [details] [diff] [review]
fix
you don't need Save()/Restore() as discussed on IRC
Attachment #215105 -
Flags: superreview?(roc) → superreview+
oh, I think you want to add PR_TRUE for snapToPixels when you call Rectangle.
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•