Update (.mar) packaging should fail if the stuff to package is missing

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
13 years ago
4 months ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

({fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
Follow-up from bug 328383.  The .mar packager (make_full_update.sh) should fail with a nonzero exit status when its source is missing, instead of successfully creating a 54-byte .mar file.
(Assignee)

Comment 1

13 years ago
Created attachment 212991 [details] [diff] [review]
Use pushd/popd to get file list and check exit status
Attachment #212991 - Flags: review?(darin)
(Assignee)

Comment 2

13 years ago
Created attachment 213001 [details] [diff] [review]
Fix both full and incremental update scripts
Assignee: nobody → mark
Status: NEW → ASSIGNED
Attachment #213001 - Flags: review?(darin)
(Assignee)

Updated

13 years ago
Attachment #212991 - Attachment is obsolete: true
Attachment #212991 - Flags: review?(darin)

Updated

13 years ago
Attachment #213001 - Flags: review?(darin) → review+
(Assignee)

Comment 3

13 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Attachment #213001 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 4

13 years ago
Fixed on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.