328678 - Xulrunner should include about:plugins support?

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Philip Langdale]

The current xulrunner package does not include plugins.html and plugins.css which are required for about:plugins to work.

It doesn't seem to make much sense to force every embedder to ship copies of these files.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

the about:plugins files should just be shipped as part of the toolkit. plugins.properties is already there, by the way.
With that fix applied, you can just remove browser/extensions/package-fixup

Comment 2

[Benjamin Smedberg]

Comment on attachment 217997 [details] [diff] [review]
Patch

Hrm, I think we probably want to move those files over here.

Comment 3

[Mike Hommey [:glandium]]

which directories would be the most appropriate ?

Comment 4

[Benjamin Smedberg]

Attachment: Move plugins.html to toolkit/content, rev. 1

Neil, this moves plugins.html/css to toolkit/content, ships xpfe from that source location. It also loads the default styling from chrome://global/content/plugins.css, which can be overridden by chrome://global/skin/plugins.css (per bug 305746).

Comment 5

[[e-mail]]

Comment on attachment 220132 [details] [diff] [review]
Move plugins.html to toolkit/content, rev. 1

>Index: toolkit/empty-file
>===================================================================
>RCS file: toolkit/empty-file
>diff -N toolkit/empty-file
patch didn't like this ;-)

>\ No newline at end of file
Would be nice to fix this :-)

>+<link rel="stylesheet" type="text/css" href="plugins.css">
Perhaps chrome: doesn't support relative URLs? I had to change this to chrome://global/content/plugins.css to get it to work. [Side note: I seem to remember reading somewhere that @import was preferred to multiple stylesheets but I forget where or why, and it probably doesn't apply here anyway.]

Comment 6

[James Ross]

(In reply to comment #5)
> >+<link rel="stylesheet" type="text/css" href="plugins.css">
> Perhaps chrome: doesn't support relative URLs?

I'm sure I've used them, but perhaps here it is resolving it against the about: protocol instead?

Comment 7

[Benjamin Smedberg]

Whoops, this fell off my radar.

Comment 8

[Benjamin Smedberg]

Fixed on trunk.