If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Xulrunner should include about:plugins support?

RESOLVED FIXED

Status

Toolkit Graveyard
XULRunner
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Philip Langdale, Assigned: Benjamin Smedberg)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
The current xulrunner package does not include plugins.html and plugins.css which are required for about:plugins to work.

It doesn't seem to make much sense to force every embedder to ship copies of these files.
Created attachment 217997 [details] [diff] [review]
Patch

the about:plugins files should just be shipped as part of the toolkit. plugins.properties is already there, by the way.
With that fix applied, you can just remove browser/extensions/package-fixup
Attachment #217997 - Flags: first-review?(benjamin)
(Assignee)

Comment 2

12 years ago
Comment on attachment 217997 [details] [diff] [review]
Patch

Hrm, I think we probably want to move those files over here.
which directories would be the most appropriate ?
(Assignee)

Comment 4

12 years ago
Created attachment 220132 [details] [diff] [review]
Move plugins.html to toolkit/content, rev. 1

Neil, this moves plugins.html/css to toolkit/content, ships xpfe from that source location. It also loads the default styling from chrome://global/content/plugins.css, which can be overridden by chrome://global/skin/plugins.css (per bug 305746).
Attachment #217997 - Attachment is obsolete: true
Attachment #220132 - Flags: first-review?(neil)
Attachment #217997 - Flags: first-review?(benjamin)

Comment 5

12 years ago
Comment on attachment 220132 [details] [diff] [review]
Move plugins.html to toolkit/content, rev. 1

>Index: toolkit/empty-file
>===================================================================
>RCS file: toolkit/empty-file
>diff -N toolkit/empty-file
patch didn't like this ;-)

>\ No newline at end of file
Would be nice to fix this :-)

>+<link rel="stylesheet" type="text/css" href="plugins.css">
Perhaps chrome: doesn't support relative URLs? I had to change this to chrome://global/content/plugins.css to get it to work. [Side note: I seem to remember reading somewhere that @import was preferred to multiple stylesheets but I forget where or why, and it probably doesn't apply here anyway.]
Attachment #220132 - Flags: first-review?(neil) → first-review+

Comment 6

12 years ago
(In reply to comment #5)
> >+<link rel="stylesheet" type="text/css" href="plugins.css">
> Perhaps chrome: doesn't support relative URLs?

I'm sure I've used them, but perhaps here it is resolving it against the about: protocol instead?

Updated

12 years ago
Blocks: 336874
(Assignee)

Comment 7

11 years ago
Whoops, this fell off my radar.
Assignee: nobody → benjamin
(Assignee)

Comment 8

11 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Blocks: 347872

Updated

6 years ago
Depends on: 703870
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.