Closed
Bug 703870
Opened 13 years ago
Closed 13 years ago
Hg remove toolkit/empty-file
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
243 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
toolkit/empty-file is zero bytes and unused - appears to have been introduced accidentally - see bug 328678 comment 5.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #575655 -
Flags: review?(benjamin)
|
||
Comment 2•13 years ago
|
||
It wasn't accidental, just a bit of an over-the-top solution to allowing themes to style plugin.html even though our themes didn't want to, by having plugin.html load global/skin/plugins.css and shipping empty versions of that for our themes. Makes for sort of amusing CVS and hg archaeology, seeing when unrelated patches removed it for each theme, though my amusement didn't extend far enough to look at why pinstripe had an actual plugins.css, but jarred empty-file instead of it.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Ah, did not know that, thank you :-)
|
||
Updated•13 years ago
|
Attachment #575655 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla11
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•