328680 - Remove nsIListControlFrame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Marc Liddell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060124 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060124 Firefox/1.5.0.1

This interface isn't necessary since only one class implements it.

Reproducible: Always

Steps to Reproduce:




I have a patch ready, waiting for bug 326944.

Comment 1

[Neil Deakin]

Attachment: Remove nsIListControlFrame interface

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 9012161 [details] [diff] [review]
Remove nsIListControlFrame interface

Not your fault, but this seems a little bit silly:
>   nsIFrame*                mDropdownFrame;           // dropdown list frame
>-  nsIListControlFrame *    mListControlFrame;        // ListControl Interface for the dropdown frame
>+  nsListControlFrame*      mListControlFrame;        // ListControl for the dropdown frame

given that it's actually the same frame:
https://searchfox.org/mozilla-central/rev/ffe6eaf2f032e58ec3b0650a87df2c62ae4ca441/layout/forms/nsComboboxControlFrame.cpp#977-978

It seems we could just change the type for mDropdownFrame
to nsListControlFrame* and get rid of mListControlFrame.

File a follow-up bug on fixing that?

Comment 3

[Mats Palmgren (inactive)]

Also, we do static_cast<nsListControlFrame*>(mDropdownFrame)
in a number of places.  We should clean that up too in that
follow-up bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d081601f722b
remove nsIListControlFrame interface, r=mats

Comment 5

[Neil Deakin]

I filed bug 1494330.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d081601f722b