329040 - Folders disappear inside folder after dragging link inside bookmark toolbar

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Martijn Wargers (dead)]

I'll attach some screenshots which hopefully makes this bug clearer and reproducable.
I think it's a regression from bug 285631. The fix for bug 326712 improved things considerably, but not this case.

To reproduce, you must have bookmark folders in the bookmarks toolbar.
The bookmark folders just before the bookmarks-chevron must have bookmark folders inside them.
Now drag an url at the beginning of the bookmarks toolbar.
After that the bookmark folders in the bookmark folder just before the bookmarks-chevron are not visible anymore. A restart of the browser or opening a new window fixes the bug.

Comment 1

[Martijn Wargers (dead)]

Attachment: Screenshot1

Here you can see the folder inside the 'nws' folder.

After this, I'm adding a bookmark at the start of the bookmarks toolbar.

Comment 2

[Martijn Wargers (dead)]

Attachment: Screenshot2

Here you can see I added a 'about:blank' bookmark to the bookmarks toolbar.
And now the folder inside the 'nws' folder has disappeared.

It only happens with the 'nws' folder, so I guess there might be some weird interaction with the bookmarks-chevron code.

Comment 3

[Neil Deakin]

I think I know what is going on here, but will need to do some testing

Comment 4

[Neil Deakin]

In case anyone wasn't aware, this bug requires a non-places build in order to reproduce it. So if we could come up with a testcase, that would be great, although I'm sure that would be hard to do.

Comment 5

[Neil Deakin]

I don't see this bug currently. Martijn, can you still reproduce it?

Comment 6

[Martijn Wargers (dead)]

(In reply to comment #5)
> I don't see this bug currently. Martijn, can you still reproduce it?

Well, I can't reproduce with current trunk build, but like you said in comment 4, one needs a non-places build to test this. Current trunk builds are places builds, afaik. Is there a place where I can download trunk non-places builds?

Comment 7

[Neil Deakin]

It's possible that the patch in bug 378173 fixes this.

Comment 8

[Martijn Wargers (dead)]

Neil, can I close this bug? (worksforme?)

Comment 9

[Martijn Wargers (dead)]

I'm marking this worksforme.
If you want to, you can reopen it, Neil.