329077 - Icons Options window gone

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Regression between 1.9a1_2006030106 and 1.9a1_2006030121.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-01+05%3A00%3A00&maxdate=2006-03-01+21%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[Ria Klaassen (not reading all bugmail)]

Hm, I see that the whole folder preferences is missing in firefox\chrome\classic.jar\skin\classic\browser\

Comment 2

[Brian Polidoro]

This appears to have been broken by Bug 328243.  That was when an #ifdef MOZ_PLACES was added to classic's jar manifest and options.png is not in that ifdef while it is in the else.

Perhaps this was done because the icons are going to be updated as part of the planned Visual/UI Refresh of Firefox.

Comment 3

[Mike Connor [:mconnor]]

No, it's a mistake, we're not going to make the refresh ifdef places ;)

Comment 4

[Wayne Woods]

In Mac OS X builds, the icons are missing from the Preferences as well, and the text seems to have lost its formatting (see especially the Privacy tab). I presume this is the same bug?

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Trunk version

Trunk, for pinstripe and winstripe.

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Branch version

Branch, winstripe only.

Comment 7

[u88484]

In my extension UI Tweaker, I have a pref window and 5 icons in...but only the middle icon is missing. Wonder why only that one and not all or none.

Comment 8

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #7)
> 
Maybe you're using a theme? :D

Comment 9

[u88484]

AHh I know why, I'm linking to it that icon only which exists in the classic.jar.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 214055 [details] [diff] [review]
Trunk version

r=[e-mail]

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 214056 [details] [diff] [review]
Branch version

r=[e-mail]

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

checked in trunk, waiting on a branch tree to work before I can land

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

landed on branch too

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv