329159 - StringIndexOutOfBoundsException in Mozilla.getGREPathFromRegistryFile

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[jhp (no longer active)]

On some Windows machines, when calling Mozilla.getGREPathWithProperties(), the user gets an exception:

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(Unknown Source)
	at java.lang.String.substring(Unknown Source)
	at org.mozilla.xpcom.Mozilla.getGREPathFromRegistryFile(Mozilla.java:344)
	at org.mozilla.xpcom.Mozilla.main(Mozilla.java:885)

Comment 1

[jhp (no longer active)]

Attachment: jx-registry.bad

This is the file created as a result of running 'regedit /e jx-registry.bad "HKEY_LOCAL_MACHINE\\Software\\mozilla.org\\GRE"' in the Mozilla.getGREPathWithProperties().  Parsing this file results in an exception.

Comment 2

[jhp (no longer active)]

Attachment: patch

The key Software\mozilla.org\GRE can itself have values, and will therefore be returned by the INIParser.  So we just use the key length to skip over this key.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 213808 [details] [diff] [review]
patch

r=mkaply

Comment 4

[jhp (no longer active)]

Checked in to trunk. -> FIXED

Comment 5

[jhp (no longer active)]

Comment on attachment 213808 [details] [diff] [review]
patch

Asking for 1.8.0.5 approval.  XULRunner only.  This patch fixes an exception that a few people are seeing.  Would be good to get in to the XULRunner 1.8.0.x nightlies.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 213808 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 7

[jhp (no longer active)]

Checked in to 1.8.0.5.