329360 - strict javascript warning: "variable event hides argument" in calendar-alarm-dialog

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: 20060303

calendar-alarm-dialog produces a strict javascript warning.



Reproducible: Always

Steps to Reproduce:
1. Enable strict javascript warnings
   Thunderbird: tools > options > advanced > config editor
   set "javascript.options.strict" to "true"

2. Set alarm and let alarm go off.


Actual Results:  
Alarm dialog appears, and the following appears in javascript console:

Warning: variable event hides argument
Source File: chrome://calendar/content/calendar-alarm-dialog.xul
Line: 1, Column: 4
Source Code:
var event = document.createEvent('Events'); event.initEvent('dismiss', false, false); this.dispatchEvent(event);

Expected Results:  
No warnings.

Code is not in the xul file shown, but in an xbl file, calendar-alarm-widget.xml, for the widget that is added for each alarm that has gone off.

Comment 1

[gekacheka]

Attachment: rename "var event" to "var dismissEvent"

(patch -l -p 2 -i file.patch)

Warning appears when dismissing the alarm.

Since 'event' is already bound in this context, rename the var to more descriptive event name: 'dismissEvent'.  Ditto for 'snoozeEvent' (currently commented out).

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 214019 [details] [diff] [review]
rename "var event" to "var dismissEvent"

Asking review, before it falls through the cracks.

Comment 3

[Joey Minta]

Comment on attachment 214019 [details] [diff] [review]
rename "var event" to "var dismissEvent"

r=jminta, although these probably want to be regular methods at some point

Comment 4

[Joey Minta]

Thanks for the patch. Checked in.

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!