Closed Bug 329431 Opened 16 years ago Closed 14 years ago
Dialog Overlay .xul cleanup for localizers
This patch cleans up some of the bad reuse and .accesskey associations that confuse localisers.
Over to Editor, since those are shared strings.
Assignee: dwayne → nobody
Component: General → Editor
Product: Thunderbird → Core
QA Contact: general → editor
Version: 1.5 → Trunk
Grr, and back to you.
Assignee: nobody → dwayne
Comment on attachment 214104 [details] [diff] [review] Fixes entity naming for localisers As phil says these are shared strings with the editor so asking the owner of the editor component for review.
Attachment #214104 - Flags: review?(daniel)
Comment on attachment 214104 [details] [diff] [review] Fixes entity naming for localisers firstname.lastname@example.org
Attachment #214104 - Flags: review?(daniel) → review+
Comment on attachment 214104 [details] [diff] [review] Fixes entity naming for localisers Perhaps an L10N note that the two labels should probably have the same text but different access keys?
Attachment #214104 - Flags: superreview?(neil) → superreview+
(In reply to comment #6) > Perhaps an L10N note that the two labels should probably have the same text but > different access keys? I don't think that will be needed since the English already indicates a choice of other accesskey. If the translator chooses conflicting ones these can be corrected as they do elsewhere.
Thanks for all the review, etc. I don't have commit rights and am also not sure what the next steps are. Is someone able to commit this patch for me?
Checking in editor/ui/dialogs/content/EdDialogOverlay.xul; /cvsroot/mozilla/editor/ui/dialogs/content/EdDialogOverlay.xul,v <-- EdDialogOverlay.xul new revision: 1.45; previous revision: 1.44 done Checking in editor/ui/locales/en-US/chrome/dialogs/EdDialogOverlay.dtd; /cvsroot/mozilla/editor/ui/locales/en-US/chrome/dialogs/EdDialogOverlay.dtd,v <-- EdDialogOverlay.dtd new revision: 1.3; previous revision: 1.2 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: EdDialogOverlay.xul cleanup for localisers → EdDialogOverlay.xul cleanup for localizers
Target Milestone: --- → mozilla1.9beta4
shouldn't "Choose File" end with U+2026 instead of three fullstop characters?
(In reply to comment #10) > shouldn't "Choose File" end with U+2026 instead of three fullstop characters? Judging from other changes I've seen in l10n related files it does seem that ... is being replaced by U+2026. I would suggest creating a new bug for that and blocking bug 329432
You need to log in before you can comment on or make changes to this bug.