Closed Bug 329432 Opened 18 years ago Closed 15 years ago

Localisation cleanup issues for Thunderbird

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwayne, Unassigned)

References

Details

(Keywords: intl)

This is a meta bug for tracking reported issues related to localisation cleanup of dtd, properties and xul files.

Items in the child bigs include:

- Bad reuse of .labels (action: usually split them out into two seperate entities and name them approriately)

- Bad accelerator keys ie not in .label text (action: create a good accelerator key)

- Bad entity naming for .accesskey (action: match .label and .acceskey so that translators can easily see that they are related)

- Bad elippsis eg .. instead of ... (action: correct)
Depends on: 329431
Depends on: 329433
Depends on: 329436
Depends on: 329438
Depends on: 329439
Depends on: 329441
Depends on: 329442
Depends on: 329444
Depends on: 329445
Depends on: 329447
Depends on: 329449
Depends on: 329451
Blocks: 329772
No longer blocks: 329772
Depends on: 329772
dwayne -> mscott: I've created a number of patches.  Each focused on one file.  Is that what you want or would you prefer one large patch?

Personally I prefer the multiple patches as its easier to make the decision to apply.  But then I'm also not the person reviewing or applying the patches to CVS.
This script:
http://pootlebugzilla.sjsoft.com/attachment.cgi?id=25

Which is part of Translate Toolkit bug 64: http://pootlebugzilla.sjsoft.com/show_bug.cgi?id=64

Helps identify permutations of .accesskey markings.  Helpful for finding items that need cleaning.
(In reply to comment #2)
> This script:
> http://pootlebugzilla.sjsoft.com/attachment.cgi?id=25
> 
> Which is part of Translate Toolkit bug 64:
> http://pootlebugzilla.sjsoft.com/show_bug.cgi?id=64
> 
> Helps identify permutations of .accesskey markings.  Helpful for finding items
> that need cleaning.

This bug and script can now be found here:
http://bugs.wordforge.org/show_bug.cgi?id=64
http://bugs.wordforge.org/attachment.cgi?id=25

Depends on: 410601
Depends on: 410797
Depends on: 413473
Depends on: 329363
Assignee: mscott → nobody
Hi Dwayne. We have a couple weeks until TB3 b1 string freeze 2008-09-16, and beta 1 driver (standard8) doubts we're going to be touching these areas.  So we'd be pleased to see these get driven in for beta, given it will help localizers. TB3 schedule https://wiki.mozilla.org/Thunderbird:Thunderbird3:Schedule  Are you up for driving in the remaining bugs for beta 1?
Flags: wanted-thunderbird3?
Keywords: intl
OS: Linux → All
Hardware: PC → All
Hi Wayne.  I'm not sure what driving these bugs would mean from me.  Does it mean checkin or asking for review, etc.  If someone is able to hold my hand through a few then I'd be more then happy to push these in.  They've sat for a while and they really will help smooth localisation.
(In reply to comment #5)
> Hi Wayne.  I'm not sure what driving these bugs would mean from me.  Does it
> mean checkin or asking for review, etc.  If someone is able to hold my hand
> through a few then I'd be more then happy to push these in.  They've sat for a
> while and they really will help smooth localisation.

If you're happy to update the patches for these bugs, and request reviews etc, then that is most of the "driving" requirement. If reviewers are slow (e.g. more than a week or two) then that's when you just need to give them a gentle reminder.

I'm certainly willing to guide you through.

http://developer.mozilla.org/En/Getting_your_patch_in_the_tree provides some useful information. For possible reviewers (depending on the area the code is in) see:

mailnews/: http://www.mozilla.org/mailnews/review.html
mail/: http://www.mozilla.org/mailnews/review-mail.html
suite/: http://www.seamonkey-project.org/dev/review-and-flags

Your first step would be to update one or more of the patches for comm-central (see http://developer.mozilla.org/en/docs/comm-central if you don't know about it already), and re-submitting it, requesting review at the same time. Make sure I'm cc'ed on the bug, and I'll guide you through as necessary.
(In reply to comment #6)
> mailnews/: http://www.mozilla.org/mailnews/review.html
> mail/: http://www.mozilla.org/mailnews/review-mail.html
> suite/: http://www.seamonkey-project.org/dev/review-and-flags

Just to note, in case you haven't realised it from those pages. mailnews/ requires review and superreview, mail/ and suite/ only require a single review. If the patch is reasonably small (like I expect most of the localisation clean ups will be) then requesting review and superreview from the same person for mailnews/ is fine (as long as they have superreview permissions!).
Depends on: 455743
Resolving as FIXED now that all dependent bugs have been closed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Thank you for the help with all these issues.
Flags: wanted-thunderbird3?
You need to log in before you can comment on or make changes to this bug.