EdImageMap.xul cleanup for localisers

RESOLVED FIXED

Status

()

Core
Editor
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Dwayne Bailey, Assigned: Dwayne Bailey)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Cleaups to .xul and associated .dtd file
(Assignee)

Updated

12 years ago
Blocks: 329432
(Assignee)

Comment 1

12 years ago
Created attachment 214107 [details] [diff] [review]
Fixes to EdImageMap.xul and EditorImageMap.dtd

Updated

10 years ago
Assignee: mscott → nobody
(Assignee)

Comment 2

10 years ago
Created attachment 337882 [details] [diff] [review]
Refresh of patch
Attachment #214107 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Attachment #337882 - Flags: review?(bugzilla)
(Assignee)

Comment 3

10 years ago
Mark-> Added you as a reviewer.  I couldn't find anyone specifically in editor/ so defaulted to you :)
Attachment #337882 - Flags: superreview?(neil)
Attachment #337882 - Flags: review?(neil)
Attachment #337882 - Flags: review?(bugzilla)
Comment on attachment 337882 [details] [diff] [review]
Refresh of patch

This seems reasonable to me, but Neil is the responsible person in this area. So I'll divert the requests (and yes I can't find a reference to reviewers for editor/ui at the moment, I just know its Neil ;-) )
That was fun - I don't know how long I spent looking for the actual UI, to see whether it was in mail's editor or only in composer's, before I finally noticed that the button to open it has been commented out since it first landed.
Component: General → Editor
Product: Thunderbird → Core
QA Contact: general → editor
Version: 1.5 → Trunk
Assignee: nobody → dwayne

Updated

10 years ago
Attachment #337882 - Flags: superreview?(neil)
Attachment #337882 - Flags: superreview+
Attachment #337882 - Flags: review?(neil)
Attachment #337882 - Flags: review+
Hi Dwayne. So now you've been granted reviews (in this case both r + sr), as (I'm assuming) you don't have permissions to push to comm-central, then you would normally add "checkin-needed" to the keywords field on the bug (without the quotes).

Then myself or someone else would come along some time later and push it to the main repository. In this case, I've already done it for you:

changeset id 314:8c88e8720ad7.

You can see this here: http://hg.mozilla.org/comm-central/pushloghtml

Whoever pushed it would remove the checkin-needed keyword and add a comment about pushing it and the changeset id (typically).

Sometimes they will mark the bug as fixed, sometimes they won't, but you should be able to do that yourself (if not, just comment and someone will come along and sort it out for you).

I'm assuming there are no other changes here, so hence I'll mark this as fixed now, and that's another bug done :-)

Thanks for doing this, hopefully this now gives you a good idea of the process. Feel free to ping me (or request reviews) if you have any problems.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Created attachment 338142 [details] [diff] [review]
remove unused strings

Additionally, according to MXR these are not used. Let's remove them.
Attachment #338142 - Flags: review?(neil)

Updated

10 years ago
Attachment #338142 - Flags: superreview+
Attachment #338142 - Flags: review?(neil)
Attachment #338142 - Flags: review+
(In reply to comment #7)
> Created an attachment (id=338142) [details]
> remove unused strings

Checked in, changeset id: 316:fafe040dd06d
(Assignee)

Comment 9

10 years ago
Thanks Mark, Vlado, Phil.  Was at a conference so missed out on being able to get these pushed myself.  Its great to see these all being checked in, much appreciated.
You need to log in before you can comment on or make changes to this bug.