329436 - EdImageMap.xul cleanup for localisers

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Dwayne Bailey]

Cleaups to .xul and associated .dtd file

Comment 1

[Dwayne Bailey]

Attachment: Fixes to EdImageMap.xul and EditorImageMap.dtd

Comment 2

[Dwayne Bailey]

Attachment: Refresh of patch

Comment 3

[Dwayne Bailey]

Mark-> Added you as a reviewer.  I couldn't find anyone specifically in editor/ so defaulted to you :)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 337882 [details] [diff] [review]
Refresh of patch

This seems reasonable to me, but Neil is the responsible person in this area. So I'll divert the requests (and yes I can't find a reference to reviewers for editor/ui at the moment, I just know its Neil ;-) )

Comment 5

[Phil Ringnalda (:philor)]

That was fun - I don't know how long I spent looking for the actual UI, to see whether it was in mail's editor or only in composer's, before I finally noticed that the button to open it has been commented out since it first landed.

Comment 6

[Mark Banner (:standard8)]

Hi Dwayne. So now you've been granted reviews (in this case both r + sr), as (I'm assuming) you don't have permissions to push to comm-central, then you would normally add "checkin-needed" to the keywords field on the bug (without the quotes).

Then myself or someone else would come along some time later and push it to the main repository. In this case, I've already done it for you:

changeset id 314:8c88e8720ad7.

You can see this here: http://hg.mozilla.org/comm-central/pushloghtml

Whoever pushed it would remove the checkin-needed keyword and add a comment about pushing it and the changeset id (typically).

Sometimes they will mark the bug as fixed, sometimes they won't, but you should be able to do that yourself (if not, just comment and someone will come along and sort it out for you).

I'm assuming there are no other changes here, so hence I'll mark this as fixed now, and that's another bug done :-)

Thanks for doing this, hopefully this now gives you a good idea of the process. Feel free to ping me (or request reviews) if you have any problems.

Comment 7

[Vlado Valastiak [:wladow]]

Attachment: remove unused strings

Additionally, according to MXR these are not used. Let's remove them.

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> Created an attachment (id=338142) [details]
> remove unused strings

Checked in, changeset id: 316:fafe040dd06d

Comment 9

[Dwayne Bailey]

Thanks Mark, Vlado, Phil.  Was at a conference so missed out on being able to get these pushed myself.  Its great to see these all being checked in, much appreciated.