329654 - calDateTimeFormatter always uses selfmade long formatted date string hack

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

calDateTimeFormatter always uses selfmade long formatted date string hack

Summary:
In the constructor of calDateTimeFormatter there is a test if the long formatted date is the same as short formatted date. If the test fails a workaround is used in formatDateLong() by building a custom long formatted date string manually.

Error:
Because the identifier 'probeString' is not defined this will always result in an exception during that test. Thus always the custom long date string is used instead of the OS specific one provided by nsIScriptableDateFormat.

Expected Result:
The OS specific date string should be used.

Reference:
http://lxr.mozilla.org/seamonkey/source/calendar/base/src/calDateTimeFormatter.js#53

Note:
Removing the 'longProbeString == probeString' part fixes this. But we should test agains the short formatted string as intended.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: init probeString with short formatted date string

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 214342 [details] [diff] [review]
init probeString with short formatted date string

Actually mvl is the correct person for this review as he wrote the original code.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 214342 [details] [diff] [review]
init probeString with short formatted date string

r=mvl

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.