330178 - Edit and Delete options are missing from Calendar tab's context menu

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andras Keri]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

The option that allows editing and deleting a calendar are missing from the Calendar tab. The option "New.." should also be available. This could lead to remove the three buttons (New, Edit, Delete), thus saving some space on the screen.

Reproducible: Always

Steps to Reproduce:
1. Well. There it is...


Expected Results:  
Enhanced context menu.

Comment 1

[Andras Keri]

Version: Lightning 0.1 RC2

Comment 2

[Andras Keri]

build: 2006031011

Comment 3

[Joey Minta]

Attachment: add options

Patch adds New, Edit, and Delete Calendar to the calendar tab panel's context menu.  I'm opposed to removing the buttons, because context menus are inherently less discoverable on Mac.  Then again, I do want to sit down and think about the calendar pane, with an eye towards more elaborate refactoring in the future.

Comment 4

[Andras Keri]

What a quick fix :)

In my opinion a better order would be:
Edig
Delete
-------
New...
Import
-------
Export
Publish...

Comment 5

[Stefan Sitter [:ssitter]]

See also Bug 327912 and my proposal at http://wiki.mozilla.org/User:Ssitter:SunbirdMenuRework#Proposal_for_Calendar_context_menu
Maybe we can make the lightning calendar context menu similar.

Comment 6

[Joey Minta]

Let's ask the experts.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

'Edit calendar' should be names 'properties' and should be the last option. That's a convetion you see everywhere in windows (and other os-es), so we should follow it. I constanty find myself almost clicking the last item, only to find out that it is something completly different.

Comment 8

[Andras Keri]

Current proposal is as follows:

----------------------------------
New Calendar...
Delete Calendar
----------------------------------
Import from File...
Export Entire Calendar...
Publish Entire Calendar...
----------------------------------
Reload Remote Calendars
Properties
----------------------------------

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #8)
> Current proposal is as follows:
> 
> ----------------------------------
> New Calendar...
> Delete Calendar
> ----------------------------------

Not sure how you feel about it, but "Rename ..." seems to be a pretty sensible option to have in the context menu as well. I wouldn't think of that action being the same as viewing the calendar properties, and it seems closer to the New/Delete operations.

> Import from File...
> Export Entire Calendar...
> Publish Entire Calendar...
> ----------------------------------

Why "entire"? Is it possible to export or publish a partial calendar? The word seems to be unneccessary.

> Reload Remote Calendars
> Properties
> ----------------------------------

The "Reload Remote Calendars" seems out of place here, in that all the other tasks are specific to the selected object, but this task is globally applied.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 214787 [details] [diff] [review]
add options

This patch doesn't seem ready for review since there's still a bunch of discussion going on in the bug here.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #9)
> > Import from File...
> > Export Entire Calendar...
> > Publish Entire Calendar...
> > ----------------------------------
> 
> Why "entire"? Is it possible to export or publish a partial calendar? The word
> seems to be unneccessary.

In Sunbird (and sometime soon in Lightning), you can export or publish just the selected events.  Still, using "Entire" here does seem a bit awkward.

> > Reload Remote Calendars
> > Properties
> > ----------------------------------
> 
> The "Reload Remote Calendars" seems out of place here, in that all the other
> tasks are specific to the selected object, but this task is globally applied.

Agreed.  The fact that this context menu happens to be on the entire tab rather than the individual items is a bug, and a bug that we should be trying to hide from user (or, better yet, fixing), I think.

Comment 12

[Stefan Sitter [:ssitter]]

Attachment: extend Calendars tab context menu

This patch exposes the same context menu commands for Calendars tab as implemented with Bug 327912 for Sunbird.
In addition some IDs are added to several xul elements so that it is easier for future extension authors and theme designers to work with Lightning.

Comment 13

[Joey Minta]

I'd like the UI-owners to sign off on bringing these changes into lightning.  I *think* the use-cases are the same here, but they should have final say.

Comment 14

[Matthew (lilmatt) Willis]

Comment on attachment 231430 [details] [diff] [review]
extend Calendars tab context menu

r1=lilmatt

Comment 15

[Stefan Sitter [:ssitter]]

Attachment: extend Calendars tab context menu, v2

Updated patch because the previous one failed to apply after the adding the date text picker control. Carry over r1+ from lilmatt and r2+ from jminta.
Content is the same in described in Comment #12. No l10n impact, only cal-ui-review required (Comment #13).

Comment 16

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED