330179 - Changing URL bookmark loses favicon

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ria Klaassen (not reading all bugmail)]

Since Bug 329797 is fixed I can change the contents of a bookmarklet. But now it changes the icon that I always use for this bookmarklet into a neutral one, what makes it hard to recognize it quickly between other bookmarklets on my toolbar.
The only way I currently know to solve this problem is to change the URL field contents of bookmarks.html in another browser, and then import it daily into the places build, but that means that I'll also lose my history every day.

Comment 1

[Brett Wilson]

When the URL of a bookmark changes, it should check with the favicon service to see if the new URL has a favicon already. If not, it should assign the previous URL's favicon to the new one.

Joe: it seems like you are accumulating a lot of specialized code to deal with changing URLs of bookmarks. I suggest that this be merged into the bookmarks service so it can be re-used.

Comment 2

[Joe Hughes]

Good point, feel free to file a bug for that...

Comment 3

[Ria Klaassen (not reading all bugmail)]

This appears to be fixed, or at least it doesn't occur anymore in Places.
I just changed an icon of a bookmarklet but it keeps to new one when I click the bookmarklet.
I'll reopen if I see it again.

Comment 4

[Ria Klaassen (not reading all bugmail)]

To be more precise, I changed the address field of an existing bookmark and it keeps the favicon.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> To be more precise, I changed the address field of an existing bookmark and it
> keeps the favicon.

This is bug 386940 now.

Comment 6

[Doug]

Can someone please reopen this bug? It does NOT work for me, and the problem described by the reporter still exists. (Or rather, it seems to have reappeared.)

Here's the situation: "http:" bookmarks can have favicons; "javascript:" bookmarks cannot. 

Previously, to get a favicon for a javascript URL, one could bookmark a site with an appropriate icon, then change the location in the bookmark properties to the desired javascript. This procedure worked fine in Firefox 2 but is broken now in Firefox 3 beta 4. Currently, changing the location to a javascript URL causes the icon to revert to the default icon.

The situation described in bug 386940 is different. When one changes the location to a new "http:" URL that HAS a favicon associated with it, one could expect the bookmark icon to also change.

But if the new location does NOT have a favicon associated with it (and javascript URLs never do), the bookmark icon should not change or revert.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv